Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: v2.29 plan: kill mtab
Date: Thu, 7 Apr 2016 12:22:06 +0100	[thread overview]
Message-ID: <201604071322.07917.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20160407105400.jn66tldxy7s3rqyc@ws.net.home>

On Thursday 07 April 2016, Karel Zak wrote:
> libmount supports three scenarios:
>
>  1) regular classic /etc/mtab
>
>  2) /etc/mtab symlink to /proc/self/mount -- in this case libmount
> uses /proc/self/mountinfo and /run/mount/utab
>
>  The current default is to detect symlink and on-the-fly switch
>  between 1) and 2).
>
>  3) --enable-libmount-force-mountinfo -- don't care about the symlink
> and always use /proc/self/mountinfo. This is robust solution required
> for example by systemd, because unfortunately sometimes people use
> broken stuff (init scripts, tools, etc.) which removes the symlink.
>
>
>  I'd like to make 3) default, the question is what with mtab code:
>
>     a) #ifdef all mtab code (and add --enable-support-mtab)
>
>     b) remove mtab support at all (because it's evil and horrible
> code)
>
>  Comments?

Even if b) is the final goal I would first do a) and mark the new 
option --enable-support-mtab as deprecated from the beginning.

Could be interesting to see who would ever use this option and because 
of which reasons.

About changing the default: We could add a warning somewhere to a 
non-critical tool when printing human-readable output, like lsblk:
  "warning: deprecated /etc/mtab file ingnored"

... just to remind people to fix their system/scripts.

cu,
Rudi

  reply	other threads:[~2016-04-07 11:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-07 10:54 v2.29 plan: kill mtab Karel Zak
2016-04-07 11:22 ` Ruediger Meier [this message]
2016-04-07 14:00 ` unrecognized options: --without-capng Marcus Hoffmann
2016-04-07 16:18   ` Mike Frysinger
2016-04-12  9:35     ` Karel Zak
2016-04-13 20:58 ` v2.29 plan: kill mtab Ruediger Meier
2016-04-14 12:43   ` Karel Zak
  -- strict thread matches above, loose matches on Subject: below --
2016-04-11  4:35 Robby Workman
2016-04-11 20:59 ` Karel Zak
2016-04-13  2:33   ` Robby Workman
2016-04-13 10:28     ` Karel Zak
2016-04-13 11:03     ` Ruediger Meier
2016-04-12  1:07 ` Isaac Dunham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201604071322.07917.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox