Re: [PATCH] libblkid: make blkid_do_wipe() work with probes with offset

[Petr Uzel <puzel@suse.cz>]

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

On Mon, Apr 18, 2016 at 08:00:18PM +0200, Karel Zak wrote:
> On Mon, Apr 18, 2016 at 04:22:05PM +0200, Petr Uzel wrote:
> > When a probe is created with an offset, e.g. via
> > blkid_probe_set_device(), this offset is correctly used when looking for
> > the signatures, but is not respected by blkid_do_wipe() function.
> > Therefore the signature is removed from an invalid location.
> 
> Wow, excellent catch. 

Thanks, feels good to again contribute a fix after such a long time :)

> How did you found it? Do you use libblkid in some partitioning tool or
> installer?

Yes, I'm trying to implement a --wipesignatures for parted - this
would wipe the signatures from a new partition, _before_ the kernel
is informed. This is to avoid mess like RAID autoassembly...

[If only there was some sane mechanism lock a device to temporarily
prevent udev from touching it :/]

> 
> Applied, thanks!

Thanks,

        Petr


-- 
Petr Uzel
TL SUSE L3 Team 2

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]