Re: [PATCH 1/3] libfdisk: Add support for altering GPT size

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

On 11 May 2016 15:54, Sassan Panahinejad wrote:
> This is useful in two situations:
> 
> 1. More than 128 partitions are required. Or
> 
> 2. The partition table must be restricted in size, such as when a system
> expects to find a bootloader at a location that would otherwise overlap the
> partition table.
> 
> The gdisk partitioner supports this feature.
> 
> libfdisk is already capable of reading and writing partition tables of any
> size, but previously could only create ones of 128 entries and could not
> resize.
> 
> This change should be fairly safe, as it has no effect unless explicitly
> activated.

i'm not super familiar with the codebase, but these look pretty nice.  thanks!

> +	fdisk_info(cxt, _("Partition table length changed from %u to %u."), old, new);

old & new are unsigned long, so you'll want %lu

> +int fdisk_set_disklabel_length(struct fdisk_context *cxt, unsigned long entries)
> +{
> +	if (!cxt || !cxt->label)
> +		return -EINVAL;
> +	if (!cxt->label->op->set_length)
> +		return -ENOSYS;
> +
> +	DBG(CXT, ul_debugobj(cxt, "setting %s label length", cxt->label->name));

want to include |entries| in the debug output too ?
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]