Util-Linux package development
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: Sassan Panahinejad <sassan@sassan.me.uk>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH v2 1/3] libfdisk: Add support for altering GPT size
Date: Fri, 13 May 2016 09:52:01 -0400	[thread overview]
Message-ID: <20160513135201.GT26300@vapier.lan> (raw)
In-Reply-To: <1463054083-2485-2-git-send-email-sassan@sassan.me.uk>

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

On 12 May 2016 12:54, Sassan Panahinejad wrote:
> +static int gpt_check_table_overlap(struct fdisk_context *cxt,
> +				   uint64_t first_usable,
> +				   uint64_t last_usable)
> +{
> ...
> +		if (gpt_partition_start(&gpt->ents[i]) < first_usable) {
> +			fdisk_warnx(cxt, _("Partition #%u out of range (minimal start is %ju sectors)"),
> +		                    i + 1, first_usable);

%j is for uintmax_t but this is uint64_t, so you'll want to use ..." PRIu64 "...

> +		if (gpt_partition_end(&gpt->ents[i]) > last_usable) {
> +			fdisk_warnx(cxt, _("Partition #%u out of range (maximal end is %ju sectors)"),
> +		                    i + 1, last_usable - 1);

same here
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-05-13 13:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 11:54 [PATCH v2 0/3] Add support for altering GPT size Sassan Panahinejad
2016-05-12 11:54 ` [PATCH v2 1/3] libfdisk: " Sassan Panahinejad
2016-05-13 13:52   ` Mike Frysinger [this message]
2016-05-13 13:54     ` Sassan Panahinejad
2016-05-12 11:54 ` [PATCH v2 2/3] fdisk: " Sassan Panahinejad
2016-05-12 11:54 ` [PATCH v2 3/3] sfdisk: " Sassan Panahinejad
2016-05-18 12:31   ` Karel Zak
2016-05-18 13:51     ` Sassan Panahinejad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160513135201.GT26300@vapier.lan \
    --to=vapier@gentoo.org \
    --cc=sassan@sassan.me.uk \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox