Util-Linux package development
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: sbrabec@suse.cz, kzak@redhat.com, util-linux@vger.kernel.org
Subject: Re: UDF label change since commit 2f2730bc77c9
Date: Wed, 10 Aug 2016 14:53:49 +0200	[thread overview]
Message-ID: <20160810125349.GC30047@pali> (raw)
In-Reply-To: <20160810123859.GA31140@quack2.suse.cz>

On Wednesday 10 August 2016 14:38:59 Jan Kara wrote:
> Hi,

Hi!

> we have noticed that since commit 2f2730bc77c9 "libblkid: udf: Fix reading
> LABEL, add support for UUID and other udf identifiers" some volumes have
> changed labels which are reported by blkid. See [1] for an example.

"You are not authorized to access bug #983165."

> This is
> because that commit changed what is used for the label - previously we have
> used 'ident' in the Primary Volume Descriptor, and after that commit we use
> Logical Volume ID.

Yes, thats true.

> I think it would be better to keep consistency with older util-linux
> releases (e.g. valid /etc/fstab that uses labels may be broken by this
> change) but I'm not sure whether there is a point once the new behavior
> has been released in the util-linux release. But still I wanted to raise
> this since I'm not sure how much util-linux cares about these changes and
> also so that people are aware of the change...
> 
> 								Honza
> 
> [1] https://bugzilla.suse.com/show_bug.cgi?id=983165
> 

Reason why I proposed that change is because all other software use
Logical Volume Identifier as label. Just linux blkid used something
other.

Basically Linux was incompatible with whole world and I think this was a
bug. Also UDF specification say something that LVI is displayed to user.
IIRC also Grub2 uses LVI as label identification.

So I do not agree with reverting back old behaviour which is
incompatible with everything except old util-linux versions...

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2016-08-10 12:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 12:38 UDF label change since commit 2f2730bc77c9 Jan Kara
2016-08-10 12:53 ` Pali Rohár [this message]
2016-08-10 13:39   ` Jan Kara
2016-08-10 14:23     ` Pali Rohár
2016-08-15  9:43       ` Jan Kara
2016-08-15 10:26         ` Pali Rohár
2016-08-16 10:21           ` Jan Kara
2017-01-28 18:46             ` Pali Rohár
2017-01-30 16:26               ` Jan Kara
2016-08-10 13:49   ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810125349.GC30047@pali \
    --to=pali.rohar@gmail.com \
    --cc=jack@suse.cz \
    --cc=kzak@redhat.com \
    --cc=sbrabec@suse.cz \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox