From: Ruediger Meier <sweet_f_a@gmx.de>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 4/5] build-sys: remove old git fallback from git-version-gen
Date: Thu, 17 Nov 2016 11:44:19 +0100 [thread overview]
Message-ID: <201611171144.19782.sweet_f_a@gmx.de> (raw)
In-Reply-To: <43681c47-6153-3100-7582-c41e7ea89d7e@bernhard-voelker.de>
On Thursday 17 November 2016, Bernhard Voelker wrote:
> On 11/17/2016 03:10 AM, Ruediger Meier wrote:
> > Just make the script more readable. Nobody is using 10 years old
> > git.
> >
> > Signed-off-by: Ruediger Meier <ruediger.meier@ga-group.nl>
> > ---
> > tools/git-version-gen | 21 ---------------------
> > 1 file changed, 21 deletions(-)
>
> Is there any particular reason not to sync from latest
> upstream (again)?
>
> http://g.sv.gnu.org/cgit/gnulib.git/tree/build-aux/git-version-gen
I only want to fix some cosmetical issues regarding our version numbers.
Don't want to risk making things worse. This particulary removed
fallback was probably never used in UL and probably broken since we've
added our special "-rc* handling.
Regarding gnulib upstream, IMO their git-version-gen is overengineered
and too complicated. We don't need any of the new
options --prefix, --fallback, --help or --version.
BTW the real upstream would be
https://github.com/git/git/blob/master/GIT-VERSION-GEN
which is simple to understand and easy to add small project-specific
changes.
cu,
Rudi
next prev parent reply other threads:[~2016-11-17 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 2:09 [PATCH 1/5] build-sys: fix empty package release number Ruediger Meier
2016-11-17 2:09 ` [PATCH 2/5] build-sys: update package release number during development Ruediger Meier
2016-11-17 2:10 ` [PATCH 3/5] build-sys: cosmetics PACKAGE_VERSION_MINOR Ruediger Meier
2016-11-17 2:10 ` [PATCH 4/5] build-sys: remove old git fallback from git-version-gen Ruediger Meier
2016-11-17 7:22 ` Bernhard Voelker
2016-11-17 10:44 ` Ruediger Meier [this message]
2016-11-17 2:10 ` [PATCH 5/5] build-sys: fix "remove the g in git describe" Ruediger Meier
2016-11-29 9:53 ` [PATCH 1/5] build-sys: fix empty package release number Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201611171144.19782.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=mail@bernhard-voelker.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox