Util-Linux package development
 help / color / mirror / Atom feed
From: Ruediger Meier <sweet_f_a@gmx.de>
To: Tilman Schmidt <tilman@imap.cc>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 1/2] misc: spelling, always use "cannot" instead of "can not"
Date: Wed, 30 Nov 2016 23:59:39 +0100	[thread overview]
Message-ID: <201611302359.40231.sweet_f_a@gmx.de> (raw)
In-Reply-To: <69f6d109-9399-5b36-73cb-a27c82a30110@imap.cc>

On Wednesday 30 November 2016, Tilman Schmidt wrote:
> Am 30.11.2016 um 15:23 schrieb Ruediger Meier:
> [...]
>
> > diff --git a/login-utils/sulogin.c b/login-utils/sulogin.c
> > index 1c4313a..a44216b 100644
> > --- a/login-utils/sulogin.c
> > +++ b/login-utils/sulogin.c
> > @@ -1012,7 +1012,7 @@ int main(int argc, char **argv)
> >  				mask_signal(SIGINT,  SIG_IGN, &saved_sigint);
> >
> >  				if (failed) {
> > -					fprintf(stderr, _("Can not execute su shell\n\n"));
> > +					fprintf(stderr, _("cannot execute su shell\n\n"));
>
> Might be better to preserve capitalization here.

I've changed it on purpose because usually we use small capitals in UL 
and no sentences (not ending with dot). This would be another thing we 
could make consistent for the whole project.

> >  					break;
> >  				}
> >  				fprintf(stderr, _("Login incorrect\n\n"));
> > @@ -1051,7 +1051,7 @@ int main(int argc, char **argv)
> >  				continue;
> >  		}
> >
> > -		errx(EXIT_FAILURE, _("Can not wait on su shell\n\n"));
> > +		errx(EXIT_FAILURE, _("cannot wait on su shell\n\n"));
>
> And here.
>
> >  	} while (1);
>
> [...]
>
> > diff --git a/sys-utils/lscpu.c b/sys-utils/lscpu.c
> > index bd702b0..e3e6ff6 100644
> > --- a/sys-utils/lscpu.c
> > +++ b/sys-utils/lscpu.c
> > @@ -886,12 +886,12 @@ is_vmware_platform(void)
> >  	act.sa_flags = SA_SIGINFO;
> >
> >  	if (sigaction(SIGSEGV, &act, &oact))
> > -		err(EXIT_FAILURE, _("error: can not set signal handler"));
> > +		err(EXIT_FAILURE, _("cannot set signal handler"));
> >
> >  	vmware_bdoor(&eax, &ebx, &ecx, &edx);
> >
> >  	if (sigaction(SIGSEGV, &oact, NULL))
> > -		err(EXIT_FAILURE, _("error: can not restore signal handler"));
> > +		err(EXIT_FAILURE, _("cannot restore signal handler"));
>
> Why drop the prefix "error: " in these two instances?
>
> Thanks,
> Tilman



      reply	other threads:[~2016-11-30 22:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 14:23 [PATCH 1/2] misc: spelling, always use "cannot" instead of "can not" Ruediger Meier
2016-11-30 14:23 ` [PATCH 2/2] misc: fix typos using codespell Ruediger Meier
2016-11-30 18:29   ` J William Piggott
2016-11-30 23:05     ` Ruediger Meier
2016-11-30 21:55 ` [PATCH 1/2] misc: spelling, always use "cannot" instead of "can not" Tilman Schmidt
2016-11-30 22:59   ` Ruediger Meier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201611302359.40231.sweet_f_a@gmx.de \
    --to=sweet_f_a@gmx.de \
    --cc=tilman@imap.cc \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox