Re: [ANNOUNCE] util-linux v2.29-rc2

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On 12 Dec 2016 15:28, Karel Zak wrote:
> I have add one AC_IF and PKG_CHECK_MODULES to our UL_NCURSES_CHECK to
> prefer pkg-config and fallback to ncurses-config. It's trivial fix and
> it seems it works as expected.

thanks

i'd also note that the current logic isn't the preferred method for
finding tools like this.  the code looks like:
  if AC_RUN_LOG([suffix[]6-config --version >/dev/null]); then

which means it runs xxx6-config directly.  in autotools, you want to:
	AC_CHECK_TOOL([NCURSES_CONFIG], [ncurses-config])
this will make it search for $host-ncurses-config first, and when
cross-compiling, it'll warn if it falls back to ncurses-config.  it
also means builders can set $NCURSES_CONFIG to whatever weird path
they want to.

based on how the current code is written, it'll be a little more
difficult to integrate.  you'd have to use like m4_translit.
untested:
	m4_define([SUFFIX], m4_translit($1, [a-z], [A-Z]))
	...
	AC_CHECK_TOOL(SUFFIX[]6_CONFIG, suffix[]6-config)
	if AC_RUN_LOG($SUFFIX[]6_CONFIG --version ....
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]