Util-Linux package development
 help / color / mirror / Atom feed
From: The Flying Rapist <impeccableenglish@gmail.com>
To: kerolasa@gmail.com
Cc: util-linux <util-linux@vger.kernel.org>,
	The Flying Rapist <admin@nosuck.org>
Subject: Re: [PATCH] col: backspacing widechars
Date: Wed, 28 Dec 2016 15:42:37 -0500	[thread overview]
Message-ID: <20161228204237.GA29001@creation> (raw)
In-Reply-To: <CAG27Bk1eCMakhnbcmQZpYVvcYF2K+eYSekaQQFxUU5UPXfa2gA@mail.gmail.com>

On 2016年12月28日 14時55分, Sami Kerola wrote:
>May I remind howto-contribute[1] tells 'using your real name (sorry,
>no pseudonyms
>or anonymous contributions.)'

I apologize.  I missed that part of howto-contribute.txt.  Please accept the following.

From: Grady Martin <admin@nosuck.org>

Until now, backspace characters have not accounted for characters of widths other than one.  This single line amends that.
---
 text-utils/col.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/text-utils/col.c b/text-utils/col.c
index 9b0e23058..c63b46fee 100644
--- a/text-utils/col.c
+++ b/text-utils/col.c
@@ -248,7 +248,7 @@ int main(int argc, char **argv)
                        case BS:                /* can't go back further */
                                if (cur_col == 0)
                                        continue;
-                               --cur_col;
+                               cur_col -= c->c_width;
                                continue;
                        case CR:
                                cur_col = 0;
--
2.11.0

  reply	other threads:[~2016-12-28 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-28  9:36 [PATCH] col: backspacing widechars The Flying Rapist
2016-12-28 14:55 ` Sami Kerola
2016-12-28 20:42   ` The Flying Rapist [this message]
2017-01-04 11:06     ` Karel Zak
2017-01-04 22:19       ` Sami Kerola
2017-01-16 11:35         ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161228204237.GA29001@creation \
    --to=impeccableenglish@gmail.com \
    --cc=admin@nosuck.org \
    --cc=kerolasa@gmail.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox