From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: Sami Kerola <kerolasa@iki.fi>
Subject: [PATCH 6/7] libblkid: declare across file variables in blkidP.h [smatch scan]
Date: Mon, 13 Feb 2017 22:06:40 +0000 [thread overview]
Message-ID: <20170213220641.1395-7-kerolasa@iki.fi> (raw)
In-Reply-To: <20170213220641.1395-1-kerolasa@iki.fi>
Else these variables will cause following warning:
libblkid/src/superblocks/superblocks.c:165:29: warning: symbol
'superblocks_drv' was not declared. Should it be static?
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
libblkid/src/blkidP.h | 5 +++++
libblkid/src/probe.c | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/libblkid/src/blkidP.h b/libblkid/src/blkidP.h
index 817c8b02b..de41473a8 100644
--- a/libblkid/src/blkidP.h
+++ b/libblkid/src/blkidP.h
@@ -116,6 +116,11 @@ struct blkid_chaindrv {
void (*free_data)(blkid_probe, void *);
};
+/* chains */
+extern const struct blkid_chaindrv superblocks_drv;
+extern const struct blkid_chaindrv topology_drv;
+extern const struct blkid_chaindrv partitions_drv;
+
/*
* Low-level probe result
*/
diff --git a/libblkid/src/probe.c b/libblkid/src/probe.c
index df90a82e0..ab05fb2d3 100644
--- a/libblkid/src/probe.c
+++ b/libblkid/src/probe.c
@@ -115,11 +115,6 @@
#include "strutils.h"
#include "list.h"
-/* chains */
-extern const struct blkid_chaindrv superblocks_drv;
-extern const struct blkid_chaindrv topology_drv;
-extern const struct blkid_chaindrv partitions_drv;
-
/*
* All supported chains
*/
--
2.11.1
next prev parent reply other threads:[~2017-02-13 22:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 22:06 [PATCH 0/7] pull: make smatch scan output easy to digest Sami Kerola
2017-02-13 22:06 ` [PATCH 1/7] cfdisk: avoid use of VLA in combination with sizeof() [smatch scan] Sami Kerola
2017-02-13 22:06 ` Sami Kerola
2017-02-13 22:06 ` [PATCH 3/7] misc: add static keyword to where needed " Sami Kerola
2017-02-13 22:06 ` [PATCH 4/7] misc: unify function declarations " Sami Kerola
2017-02-13 22:06 ` [PATCH 5/7] lib/idcache: add void to function declaration " Sami Kerola
2017-02-13 22:06 ` Sami Kerola [this message]
2017-02-13 22:06 ` [PATCH 7/7] findmnt: fix couple memory leaks [cppcheck] Sami Kerola
2017-02-20 12:14 ` [PATCH 0/7] pull: make smatch scan output easy to digest Karel Zak
2017-02-20 22:12 ` Sami Kerola
2017-02-21 9:50 ` Karel Zak
2017-02-24 0:37 ` Dan Carpenter
2017-02-25 17:32 ` Sami Kerola
2017-02-25 20:09 ` Dan Carpenter
2017-02-26 4:07 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213220641.1395-7-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox