From: Ruediger Meier <sweet_f_a@gmx.de>
To: J William Piggott <elseifthen@gmx.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 6/6] misc: fix some warnings
Date: Tue, 6 Jun 2017 10:10:07 +0200 [thread overview]
Message-ID: <201706061010.07911.sweet_f_a@gmx.de> (raw)
In-Reply-To: <0035d164-75ac-f892-2cbe-0fb8184116cb@gmx.com>
On Thursday 01 June 2017, J William Piggott wrote:
> On 05/31/2017 09:08 PM, Ruediger Meier wrote:
> > From: Ruediger Meier <ruediger.meier@ga-group.nl>
>
> 8< ---
>
> > diff --git a/lib/plymouth-ctrl.c b/lib/plymouth-ctrl.c
> > index 75d8b93..0e60341 100644
> > --- a/lib/plymouth-ctrl.c
> > +++ b/lib/plymouth-ctrl.c
> > @@ -85,7 +85,8 @@ static int open_un_socket_and_connect(void)
> > * Please note that the PLYMOUTH_SOCKET_PATH has a
> > * leading NULL byte to mark it as an abstract socket
> > */
> > - ret = connect(fd, &su, offsetof(struct sockaddr_un, sun_path) + 1
> > + strlen(su.sun_path+1)); + ret = connect(fd, (const struct
> > sockaddr *) &su,
> > + offsetof(struct sockaddr_un, sun_path) + 1 +
> > strlen(su.sun_path+1));
>
> ^^^^^^^^^^^^^^ whitespace
>
> 8< ---
What would be the right whitespace style? I've made one indentation
(tab) and some spaces to align the broken line regarding "connect(".
I'm using tab only for indentation but not for alignment, to let it look
nice independently of editors tab witdth. Is that wrong?
cu,
Rudi
next prev parent reply other threads:[~2017-06-06 8:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 1:08 [PATCH 0/6] minor last minute fixes for v2.30 Ruediger Meier
2017-06-01 1:08 ` [PATCH 1/6] tests: grep's short option -A is more portable Ruediger Meier
2017-06-01 1:08 ` [PATCH 2/6] tests: avoid diff of diffs Ruediger Meier
2017-06-01 1:08 ` [PATCH 3/6] build-sys: fix library order when linking Ruediger Meier
2017-06-01 1:08 ` [PATCH 4/6] tests: use stdbuf when stderr and stdout is randomly ordered Ruediger Meier
2017-06-01 1:08 ` [PATCH 5/6] tests: handle non glibc error message for fallocate Ruediger Meier
2017-06-01 1:08 ` [PATCH 6/6] misc: fix some warnings Ruediger Meier
2017-06-01 18:50 ` J William Piggott
2017-06-06 8:10 ` Ruediger Meier [this message]
2017-06-06 18:18 ` J William Piggott
2017-06-06 19:17 ` J William Piggott
2017-06-07 15:27 ` Sami Kerola
2017-06-07 17:09 ` Bruce Dubbs
2017-06-07 23:39 ` Ruediger Meier
2017-06-08 5:26 ` Bernhard Voelker
2017-06-01 7:52 ` [PATCH 0/6] minor last minute fixes for v2.30 Ruediger Meier
2017-06-01 8:55 ` Karel Zak
2017-06-01 9:15 ` Ruediger Meier
2017-06-01 10:32 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201706061010.07911.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=elseifthen@gmx.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox