util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bash-completion: simplify pid listing
@ 2017-08-26 12:45 Sami Kerola
  0 siblings, 0 replies; only message in thread
From: Sami Kerola @ 2017-08-26 12:45 UTC (permalink / raw)
  To: util-linux; +Cc: Sami Kerola

Changing directory in subshell does not effect parent process, so this is
better and possibly quicker way to list pids.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 bash-completion/nsenter | 2 +-
 bash-completion/prlimit | 2 +-
 bash-completion/renice  | 2 +-
 bash-completion/taskset | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bash-completion/nsenter b/bash-completion/nsenter
index ceea61001..ad56f06e4 100644
--- a/bash-completion/nsenter
+++ b/bash-completion/nsenter
@@ -15,7 +15,7 @@ _nsenter_module()
 			;;
 		'-t'|'--target')
 			local PIDS
-			PIDS=$(for I in /proc/[0-9]*; do echo ${I##"/proc/"}; done)
+			PIDS=$(cd /proc && echo [0-9]*)
 			COMPREPLY=( $(compgen -W "$PIDS" -- $cur) )
 			return 0
 			;;
diff --git a/bash-completion/prlimit b/bash-completion/prlimit
index f5e00bb16..fc60c6461 100644
--- a/bash-completion/prlimit
+++ b/bash-completion/prlimit
@@ -6,7 +6,7 @@ _prlimit_module()
 	prev="${COMP_WORDS[COMP_CWORD-1]}"
 	case $prev in
 		'-p'|'--pid')
-			PIDS=$(for I in /proc/[0-9]*; do echo ${I##"/proc/"}; done)
+			PIDS=$(cd /proc && echo [0-9]*)
 			COMPREPLY=( $(compgen -W "$PIDS" -- $cur) )
 			return 0
 			;;
diff --git a/bash-completion/renice b/bash-completion/renice
index c3e9331b0..2495f3785 100644
--- a/bash-completion/renice
+++ b/bash-completion/renice
@@ -17,7 +17,7 @@ _renice_module()
 			;;
 		'-p'|'--pid')
 			local PIDS
-			PIDS=$(for I in /proc/[0-9]*; do echo ${I##"/proc/"}; done)
+			PIDS=$(cd /proc && echo [0-9]*)
 			COMPREPLY=( $(compgen -W "$PIDS" -- $cur) )
 			return 0
 			;;
diff --git a/bash-completion/taskset b/bash-completion/taskset
index 8e62a3b67..453b17b4a 100644
--- a/bash-completion/taskset
+++ b/bash-completion/taskset
@@ -25,7 +25,7 @@ _taskset_module()
 			# setting an affinity the optarg has to be cpu
 			# mask.  The following is good only for getting
 			# affinity.
-			PIDS=$(for I in /proc/[0-9]*; do echo ${I##"/proc/"}; done)
+			PIDS=$(cd /proc && echo [0-9]*)
 			COMPREPLY=( $(compgen -W "$PIDS" -- $cur) )
 			return 0
 			;;
-- 
2.14.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-08-26 12:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-26 12:45 [PATCH] bash-completion: simplify pid listing Sami Kerola

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).