From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: Sami Kerola <kerolasa@iki.fi>
Subject: [PATCH] libuuid: use explicit_bzero() in uuid_clear() when possible
Date: Mon, 16 Oct 2017 22:37:34 +0100 [thread overview]
Message-ID: <20171016213734.23237-1-kerolasa@iki.fi> (raw)
This ensures value is blanked. It is possible compiler optimization removed
earlier uuid_clear() calls as unnecessary if value was not used after clear.
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
libuuid/src/clear.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libuuid/src/clear.c b/libuuid/src/clear.c
index 2d91fee93..5b1392464 100644
--- a/libuuid/src/clear.c
+++ b/libuuid/src/clear.c
@@ -38,6 +38,10 @@
void uuid_clear(uuid_t uu)
{
+#ifdef HAVE_EXPLICIT_BZERO
+ explicit_bzero(uu, 16);
+#else
memset(uu, 0, 16);
+#endif
}
--
2.14.2
next reply other threads:[~2017-10-16 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 21:37 Sami Kerola [this message]
2017-10-18 7:15 ` [PATCH] libuuid: use explicit_bzero() in uuid_clear() when possible Christoph Hellwig
2017-10-23 19:38 ` Sami Kerola
2017-10-24 9:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016213734.23237-1-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).