From: Karel Zak <kzak@redhat.com>
To: J William Piggott <elseifthen@gmx.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 4/4] lib/timeutils: add common ISO timestamp masks
Date: Thu, 2 Nov 2017 14:45:40 +0100 [thread overview]
Message-ID: <20171102134540.o5dhvgwil2ykevdy@ws.net.home> (raw)
In-Reply-To: <8421ce81-278a-65d9-9470-bc86e3103b73@gmx.com>
On Tue, Oct 24, 2017 at 12:19:59PM -0400, J William Piggott wrote:
> Anyway, I'm not clear on what you want me to do. You didn't comment on
> my idea that naming the radix point implies usec.
Yes, it implies usec, the question is if such thing is obvious for a
random reader.
> Why define a radix
> point if there is no fractional part, it makes no sense. If you agree
> with that, then your only remaining change request is moving the _G
> suffix to _GM prefix. Is that the only change you want? If yes, then
> I'll make it so. IMO, it degrades readability, but you have the hammer.
Just brainstorming... the current situation is not so bad from my point
of view :-)
Anyway I don't see a problem to support complete macros ISO_TIMESTAMP_
as you suggested, but please keep it without magic number with in the
header files. The _G suffix is fine. Send patch.
It would be also nice to use all the complex macros in lib/timeutils.c
test program.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
prev parent reply other threads:[~2017-11-02 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-23 0:37 [PATCH 0/4] Pull Request J William Piggott
2017-10-23 0:38 ` [PATCH 1/4] hwclock: add iso-8601 overflow check J William Piggott
2017-10-23 0:39 ` [PATCH 2/4] lib/timeutils: ISO_8601_BUFSIZ too small J William Piggott
2017-10-23 0:40 ` [PATCH 3/4] lib/timeutils: add get_gmtoff() J William Piggott
2017-10-23 0:41 ` [PATCH 4/4] lib/timeutils: add common ISO timestamp masks J William Piggott
2017-10-23 9:49 ` Karel Zak
2017-10-23 19:54 ` J William Piggott
2017-10-24 9:37 ` Karel Zak
2017-10-24 16:19 ` J William Piggott
2017-11-02 13:45 ` Karel Zak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102134540.o5dhvgwil2ykevdy@ws.net.home \
--to=kzak@redhat.com \
--cc=elseifthen@gmx.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).