* v2.31.1 plan
@ 2017-12-14 15:00 Karel Zak
2017-12-15 12:01 ` Rüdiger Meier
0 siblings, 1 reply; 5+ messages in thread
From: Karel Zak @ 2017-12-14 15:00 UTC (permalink / raw)
To: util-linux
I'd like to release stable maintenance v2.31.1 tomorrow or on Monday.
All is already in stable/v2.31 branch:
https://github.com/karelzak/util-linux/tree/stable/v2.31
See log below, comments & objections?
Note that some invasive bug fixes like libblkid UDF changes (Pali)
or some date/time cleanups (jwp) are missing.
Karel
bash-completion:
- Exclude /dev/fd from fsck find [Kevin Locke]
blkid:
- Add support for LUKS2 and new LABEL attributes. [Milan Broz]
blockdev:
- be more explicit for BLKSSZ in blockdev.8 [Karel Zak]
build-sys:
- move rfkill to /usr/sbin [Karel Zak]
column:
- use \x<hex> for invalid multibyte seq. [Karel Zak]
dmesg:
- add note about -F format to the man page [Karel Zak]
docs:
- improve setarch(8) manual page [Sami Kerola]
fincore:
- fix a typo in fincore.1 [Masatake YAMATO]
fsck.cramfs:
- Fix bus error on broken file system. [Tobias Stoeckmann]
hwclock:
- add iso-8601 overflow check [J William Piggott]
- fix debug regression [J William Piggott]
- revert ioctl test [Karel Zak]
lib/mbsalign:
- add mbs_invalid_encode() [Karel Zak]
lib/md5:
- use ul_/UL_ prefix [Karel Zak]
lib/sha1:
- use ul_/UL_prefix for symbols [Karel Zak]
lib/timeutils:
- ISO_8601_BUFSIZ too small [J William Piggott]
libblkid:
- vfat Fix reading labels which starts with byte 0x05 [Pali Rohár]
libfdisk:
- (sun) enhance searching of free space [Mikhail Vorobyov]
- (sun) fix creation of whole disk partition [Mikhail Vorobyov]
- (sun) move aligning of the first sector before availability check [Mikhail Vorobyov]
- Fix uninitialized structure [Roddy Shuler]
libmount:
- Allow MNT_FORCE and MNT_DETACH at umount [Joshua Watt]
- add nsfs between pseudo filesystems [Karel Zak]
libsmartcols:
- don't add blank padding after left aligned title [Karel Zak]
lsblk:
- add hint about perms to man page [Karel Zak]
lscpu:
- Treat read failure on Xen Hypervisor properties as non-fatal [Dirk Mueller]
lslocks:
- add note about OFDLCK [Karel Zak]
man:
- use long options in text and add example to uuidgen [Sami Kerola]
mcookie:
- properly initialize hash [Karel Zak]
md5:
- declare byteReverse as static [Luca Ceresoli]
misc:
- fix typos [Sami Kerola]
mount:
- add hint about -t and root perms to the man page [Karel Zak]
- add more details about UUIDs and LABELs to the man page [Karel Zak]
nsenter:
- fix compiler warning [-Wuninitialized] [Karel Zak]
rtcwake:
- add note about HW and sleep to the man page [Karel Zak]
- fix sys vs. rtc time delta usage [Karel Zak]
sample-scols-title:
- add left title without padding [Karel Zak]
sfdisk:
- create empty label on 'write' command [Karel Zak]
test_sha1:
- update helper [Karel Zak]
tests:
- add LUKS test images [Milan Broz]
- add fsck.cramfs bad-header test [Karel Zak]
- update columns test due to dda229c7b2b16a31fae8e99079ab4f4ae5bc8eac [Karel Zak]
- update libsmartcols/title [Karel Zak]
vipw:
- do not let editor to inherit open file descriptors [Sami Kerola]
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: v2.31.1 plan
2017-12-14 15:00 v2.31.1 plan Karel Zak
@ 2017-12-15 12:01 ` Rüdiger Meier
2017-12-19 10:52 ` Karel Zak
0 siblings, 1 reply; 5+ messages in thread
From: Rüdiger Meier @ 2017-12-15 12:01 UTC (permalink / raw)
To: Karel Zak, util-linux
On 12/14/2017 04:00 PM, Karel Zak wrote:
>
> I'd like to release stable maintenance v2.31.1 tomorrow or on Monday.
>
> All is already in stable/v2.31 branch:
> https://github.com/karelzak/util-linux/tree/stable/v2.31
>
> See log below, comments & objections?
I have one, probably minor issue which I was too lazy to investigate
so far.
Test mount/fslists-type-pattern fails if you have /sbin/mount.exfat installed.
cu,
Rudi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v2.31.1 plan
2017-12-15 12:01 ` Rüdiger Meier
@ 2017-12-19 10:52 ` Karel Zak
0 siblings, 0 replies; 5+ messages in thread
From: Karel Zak @ 2017-12-19 10:52 UTC (permalink / raw)
To: Rüdiger Meier; +Cc: util-linux
On Fri, Dec 15, 2017 at 01:01:23PM +0100, Rüdiger Meier wrote:
> On 12/14/2017 04:00 PM, Karel Zak wrote:
> >
> > I'd like to release stable maintenance v2.31.1 tomorrow or on Monday.
> >
> > All is already in stable/v2.31 branch:
> > https://github.com/karelzak/util-linux/tree/stable/v2.31
> >
> > See log below, comments & objections?
>
> I have one, probably minor issue which I was too lazy to investigate
> so far.
>
> Test mount/fslists-type-pattern fails if you have /sbin/mount.exfat installed.
It sounds strange and I cannot reproduce this problem.
# ls -la /sbin/mount.exfat
lrwxrwxrwx 1 root root 16 Jun 21 16:27 /sbin/mount.exfat -> mount.exfat-fuse
# ./tests/ts/mount/fslists
mount: fs lists ...
: one-type ... OK
: more-types ... OK
: more-types-fstab ... OK
: type-pattern ... OK
: type-pattern-neg ... OK
... OK (all 5 sub-tests PASSED)
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v2.31.1 plan
@ 2017-12-19 11:50 Ruediger Meier
2017-12-19 12:45 ` Karel Zak
0 siblings, 1 reply; 5+ messages in thread
From: Ruediger Meier @ 2017-12-19 11:50 UTC (permalink / raw)
To: util-linux
On Tuesday 19 December 2017 at 11:52, you wrote:
> On Fri, Dec 15, 2017 at 01:01:23PM +0100, Rüdiger Meier wrote:
> > On 12/14/2017 04:00 PM, Karel Zak wrote:
> > > I'd like to release stable maintenance v2.31.1 tomorrow or on
> > > Monday.
> > >
> > > All is already in stable/v2.31 branch:
> > > https://github.com/karelzak/util-linux/tree/stable/v2.31
> > >
> > > See log below, comments & objections?
> >
> > I have one, probably minor issue which I was too lazy to
> > investigate so far.
> >
> > Test mount/fslists-type-pattern fails if you have /sbin/mount.exfat
> > installed.
>
> It sounds strange and I cannot reproduce this problem.
>
> # ls -la /sbin/mount.exfat
> lrwxrwxrwx 1 root root 16 Jun 21 16:27 /sbin/mount.exfat ->
> mount.exfat-fuse
>
> # ./tests/ts/mount/fslists
> mount: fs lists ...
>
> : one-type ... OK
> : more-types ... OK
> : more-types-fstab ... OK
> : type-pattern ... OK
> : type-pattern-neg ... OK
>
> ... OK (all 5 sub-tests PASSED)
>
>
> Karel
I can reproduce it trying to mount an ext4 device using "-t nofoo,bar"
like in the test, as you see below. I'm not sure whether the bad return
value of mount.exfat is the problem or why mount is trying mount.exfat
(and friends) at all.
$ sudo LIBMOUNT_DEBUG=0xffff ./mount -t nofoo,bar /dev/vg0/root /mnt/tmp
6682: libmount: INIT: library debug mask: 0xffff
6682: libmount: INIT: library version: 2.31.157
6682: libmount: INIT: feature: btrfs
6682: libmount: INIT: feature: assert
6682: libmount: INIT: feature: debug
Available "LIBMOUNT_DEBUG=<name>[,...]|<mask>" debug masks:
all [0xffff] : info about all subsystems
cache [0x0004] : paths and tags cache
cxt [0x0200] : library context (handler)
diff [0x0400] : mountinfo changes tracking
fs [0x0040] : FS abstraction
help [0x0001] : this help
locks [0x0010] : mtab and utab locking
loop [0x2000] : loop devices routines
options [0x0008] : mount options parsing
tab [0x0020] : fstab, mtab, mountinfo routines
update [0x0080] : mtab, utab updates
utils [0x0100] : misc library utils
monitor [0x0800] : mount tables monitor
btrfs [0x1000] : btrfs specific routines
6682: libmount: CXT: [0x1f00fb0]: ----> allocate
6682: libmount: CXT: [0x1f00fb0]: mount: preparing
6682: libmount: CXT: [0x1f00fb0]: use default optsmode
6682: libmount: CXT: [0x1f00fb0]: OPTSMODE: ignore=0, append=0,
prepend=1, replace=0, force=0, fstab=1, mtab=1
6682: libmount: CXT: [0x1f00fb0]: fstab not required -- skip
6682: libmount: CXT: [0x1f00fb0]: merging mount flags
6682: libmount: CXT: [0x1f00fb0]: final flags: VFS=00000000
user=00000000
6682: libmount: CXT: [0x1f00fb0]: mount: evaluating permissions
6682: libmount: CXT: [0x1f00fb0]: mount: fixing optstr
6682: libmount: CXT: [0x1f00fb0]: mount: fixing vfs optstr
6682: libmount: CXT: applying 0x00000000 flags to '(null)'
6682: libmount: CXT: new optstr 'rw'
6682: libmount: CXT: [0x1f00fb0]: mount: fixing user optstr
6682: libmount: CXT: applying 0x00000000 flags to '(null)'
6682: libmount: CXT: new optstr '(null)'
6682: libmount: CXT: [0x1f00fb0]: fixed options [rc=0]: vfs: 'rw'
fs: '(null)' user: '(null)', optstr: 'rw'
6682: libmount: CXT: [0x1f00fb0]: preparing source path
6682: libmount: CXT: [0x1f00fb0]: srcpath '/dev/vg0/root'
6682: libmount: CACHE: [0x1f01230]: alloc
6682: libmount: CACHE: [0x1f01230]: canonicalize path /dev/vg0/root
6682: libmount: CACHE: [0x1f01230]: add entry [ 1]
(path): /dev/mapper/vg0-root: /dev/vg0/root
6682: libmount: CXT: [0x1f00fb0]: final
srcpath '/dev/mapper/vg0-root'
6682: libmount: CXT: [0x1f00fb0]: preparing target path
6682: libmount: CACHE: [0x1f01230]: canonicalize path /mnt/tmp
6682: libmount: CACHE: [0x1f01230]: add entry [ 2]
(path): /mnt/tmp: /mnt/tmp
6682: libmount: CXT: [0x1f00fb0]: final target '/mnt/tmp'
6682: libmount: CXT: [0x1f00fb0]: preparing fstype
6682: libmount: CXT: [0x1f00fb0]: FS type: (null) [rc=0]
6682: libmount: CXT: [0x1f00fb0]: prepare update
6682: libmount: CXT: [0x1f00fb0]: checking for writable tab files
6682: libmount: UTILS: utab: /run/mount/utab
6682: libmount: UTILS: try write /run/mount/utab dir: (null)
6682: libmount: UTILS: access OK
6682: libmount: UPDATE: [0x1f01ec0]: allocate
6682: libmount: UPDATE: [0x1f01ec0]: resetting FS [fs=0x0x1f010b0,
target=(null), flags=0x00000000]
6682: libmount: UPDATE: [0x1f01ec0]: FS template:
6682: libmount: UPDATE: ------ fs: 0x1f010b0
source: /dev/mapper/vg0-root
target: /mnt/tmp
fstype: (null)
optstr: rw
VFS-optstr: rw
6682: libmount: UPDATE: prepare utab entry
6682: libmount: UPDATE: utab entry unnecessary (no options)
6682: libmount: CXT: [0x1f00fb0]: mount: do mount
6682: libmount: CXT: [0x1f00fb0]: trying to mount by FS
pattern 'nofoo,bar'
6682: libmount: UTILS: reading filesystems list
from: /etc/filesystems
6682: libmount: UTILS: reading filesystems list
from: /proc/filesystems
6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.vfat ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs.d/mount.vfat ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs/mount.vfat ... not
found
6682: libmount: CXT: [0x1f00fb0]: mount(2)
[source=/dev/mapper/vg0-root, target=/mnt/tmp, type=vfat,
mountflags=0xc0ed8000, mountdata=<none>]
6682: libmount: CXT: [0x1f00fb0]: mount(2) failed [errno=22 Invalid
argument]
6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.hfs ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs.d/mount.hfs ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs/mount.hfs ... not
found
6682: libmount: CXT: [0x1f00fb0]: mount(2)
[source=/dev/mapper/vg0-root, target=/mnt/tmp, type=hfs,
mountflags=0xc0ed8000, mountdata=<none>]
6682: libmount: CXT: [0x1f00fb0]: mount(2) failed [errno=22 Invalid
argument]
6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.minix ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs.d/mount.minix ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs/mount.minix ... not
found
6682: libmount: CXT: [0x1f00fb0]: mount(2)
[source=/dev/mapper/vg0-root, target=/mnt/tmp, type=minix,
mountflags=0xc0ed8000, mountdata=<none>]
6682: libmount: CXT: [0x1f00fb0]: mount(2) failed [errno=22 Invalid
argument]
6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.reiserfs ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs.d/mount.reiserfs ... not
found
6682: libmount: CXT: [0x1f00fb0]: /sbin/fs/mount.reiserfs ... not
found
6682: libmount: CXT: [0x1f00fb0]: mount(2)
[source=/dev/mapper/vg0-root, target=/mnt/tmp, type=reiserfs,
mountflags=0xc0ed8000, mountdata=<none>]
6682: libmount: CXT: [0x1f00fb0]: mount(2) failed [errno=22 Invalid
argument]
6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.exfat ...
found
6682: libmount: CXT: [0x1f00fb0]: mount: executing
helper /sbin/mount.exfat
6682: libmount: CXT: [0x1f00fb0]: mount: generate helper mount
options
6697: libmount: CXT: [0x1f00fb0]: argv[0] = "/sbin/mount.exfat"
6697: libmount: CXT: [0x1f00fb0]: argv[1] = "/dev/mapper/vg0-root"
6697: libmount: CXT: [0x1f00fb0]: argv[2] = "/mnt/tmp"
6697: libmount: CXT: [0x1f00fb0]: argv[3] = "-o"
6697: libmount: CXT: [0x1f00fb0]: argv[4] = "rw"
FUSE exfat 1.2.6
ERROR: exFAT file system is not found.
6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.exfat executed
[status=1, rc=0]
6682: libmount: CXT: [0x1f00fb0]: don't update: no update prepared
6682: libmount: CXT: [0x1f00fb0]: excode: rc=1 message=""
6682: libmount: CXT: [0x1f00fb0]: <---- reset [status=1] ---->
6682: libmount: FS: [0x1f010b0]: free [refcount=0]
6682: libmount: CACHE: [0x1f01230]: free [refcount=0]
6682: libmount: UPDATE: [0x1f01ec0]: free
6682: libmount: CXT: [0x1f00fb0]: <---- free
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: v2.31.1 plan
2017-12-19 11:50 Ruediger Meier
@ 2017-12-19 12:45 ` Karel Zak
0 siblings, 0 replies; 5+ messages in thread
From: Karel Zak @ 2017-12-19 12:45 UTC (permalink / raw)
To: Ruediger Meier; +Cc: util-linux
On Tue, Dec 19, 2017 at 12:50:51PM +0100, Ruediger Meier wrote:
> I can reproduce it trying to mount an ext4 device using "-t nofoo,bar"
> like in the test, as you see below. I'm not sure whether the bad return
> value of mount.exfat is the problem or why mount is trying mount.exfat
> (and friends) at all.
"-t <name>" specifies FS type and forces mount(8) do not use built-in
(libblkid) FS detection. It's good enough if you provide fstype by <name>.
If you specify "-t [no]<list>" then it disables built-in detection and
define what FS types are [un]wanted. If built-in detection is disabled,
and FS type is unknown, so it reads /{etc,proc}/filesystems and
filter out filesystem types by your [no]<list> pattern.
The final list of wanted filesystems is tried for mount.<type> helpers
or by direct mount(2) syscall.
The problem is that function do_mount_by_pattern() cares about exec()
return code, but don't care about waitpid() status from the helper.
I'll fix it in the master branch. For stable branch we can add "-i"
(disable helpers) to the test.
The reason why I don't this problem is that Fedora have ext4 as the
first FS in the /etc/filesystems and I'd have exfat in the lists at
all.
> 6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.exfat ...
> found
> 6682: libmount: CXT: [0x1f00fb0]: mount: executing
> helper /sbin/mount.exfat
> 6682: libmount: CXT: [0x1f00fb0]: mount: generate helper mount
> options
> 6697: libmount: CXT: [0x1f00fb0]: argv[0] = "/sbin/mount.exfat"
> 6697: libmount: CXT: [0x1f00fb0]: argv[1] = "/dev/mapper/vg0-root"
> 6697: libmount: CXT: [0x1f00fb0]: argv[2] = "/mnt/tmp"
> 6697: libmount: CXT: [0x1f00fb0]: argv[3] = "-o"
> 6697: libmount: CXT: [0x1f00fb0]: argv[4] = "rw"
> FUSE exfat 1.2.6
> ERROR: exFAT file system is not found.
> 6682: libmount: CXT: [0x1f00fb0]: /sbin/mount.exfat executed
> [status=1, rc=0]
^^^^^^^^^^^^^
We need to try another FS for status=1.
Thanks!
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-12-19 12:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-14 15:00 v2.31.1 plan Karel Zak
2017-12-15 12:01 ` Rüdiger Meier
2017-12-19 10:52 ` Karel Zak
-- strict thread matches above, loose matches on Subject: below --
2017-12-19 11:50 Ruediger Meier
2017-12-19 12:45 ` Karel Zak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).