From: Theodore Ts'o <tytso@mit.edu>
To: Karel Zak <kzak@redhat.com>
Cc: Peter Cordes <peter@cordes.ca>,
util-linux@vger.kernel.org, Hornseth_Brenan@bah.com
Subject: Re: [PATCH] fsck: use xasprintf to avoid buffer overruns with an insane fs type
Date: Sat, 17 Feb 2018 01:46:53 -0500 [thread overview]
Message-ID: <20180217064653.GH12890@thunk.org> (raw)
In-Reply-To: <20180216180820.ay7plq2du5xjwqms@ws.net.home>
On Fri, Feb 16, 2018 at 07:08:20PM +0100, Karel Zak wrote:
>
> Maybe all we need is to check -t argument and reject non-senses
> already in main() ;-)
I also thought about rejecting any file system type larger than, say,
16 characters. Then I looked at the kernel code, and in theory
there's nothing stopping someone from creating an out-of-tree kernel
file system with a file system type of, say, for example:
supercalifragilisticexpialidocious
:-)
- Ted
prev parent reply other threads:[~2018-02-17 6:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 20:05 [PATCH] fsck: use xasprintf to avoid buffer overruns with an insane fs type Theodore Ts'o
2018-02-16 9:54 ` Karel Zak
2018-02-16 15:55 ` Peter Cordes
2018-02-16 17:10 ` Theodore Ts'o
2018-02-16 18:08 ` Karel Zak
2018-02-17 0:29 ` Peter Cordes
2018-02-17 6:46 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217064653.GH12890@thunk.org \
--to=tytso@mit.edu \
--cc=Hornseth_Brenan@bah.com \
--cc=kzak@redhat.com \
--cc=peter@cordes.ca \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox