From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Sami Kerola <kerolasa@iki.fi>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] libuuid: use kernel crypto api
Date: Sat, 4 Aug 2018 15:46:55 -0400 [thread overview]
Message-ID: <20180804194655.GD4461@thunk.org> (raw)
In-Reply-To: <20180804191706.10641-1-kerolasa@iki.fi>
On Sat, Aug 04, 2018 at 08:17:06PM +0100, Sami Kerola wrote:
> Try to speed up md5 checksums by using hardware accelerators when they are
> present with use of kernel crypto api.
>
> Reference: http://www.chronox.de/libkcapi/html/ch01s02.html
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
I'm not sure I see the point of this change. Is there a use case you
have in mind where people would be using crypto hash based UUID's
where performance is a concern? In in that case where someone was
trying to create a huge number of crypto hash based UUID's, how much
overhead is there in going through the kernel API if there is *not* a
hardware accelerator present?
- Ted
next prev parent reply other threads:[~2018-08-04 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 19:17 [PATCH] libuuid: use kernel crypto api Sami Kerola
2018-08-04 19:27 ` Dmitry V. Levin
2018-08-04 19:46 ` Theodore Y. Ts'o [this message]
2018-08-05 10:42 ` Sami Kerola
2018-08-05 23:41 ` Peter Cordes
2018-08-06 6:56 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180804194655.GD4461@thunk.org \
--to=tytso@mit.edu \
--cc=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox