Util-Linux package development
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Jeffrey Ferreira <jeffpferreira@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] losetup: set blocksize before partition scan
Date: Tue, 22 Jan 2019 11:57:45 +0100	[thread overview]
Message-ID: <20190122105745.sooe63gdchnp5uwd@ws.net.home> (raw)
In-Reply-To: <20190110215515.GA28589@jeffrey-Ubuntu-iMac>

On Thu, Jan 10, 2019 at 01:55:19PM -0800, Jeffrey Ferreira wrote:
> When creating a loop device the user may use the --partscan option to
> request that the kernel scan for partitions. To correctly scan for
> partitions the kernel must first have the correct blocksize.

Really good catch. Thanks!

I have implemented it in a little different way to follow internal API
from lib/loopdev.c.

> Also, update an error message to add --partscan to the list of options
> only allowed during loop device setup.

Merged this part.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

      reply	other threads:[~2019-01-22 10:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 21:55 [PATCH] losetup: set blocksize before partition scan Jeffrey Ferreira
2019-01-22 10:57 ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122105745.sooe63gdchnp5uwd@ws.net.home \
    --to=kzak@redhat.com \
    --cc=jeffpferreira@gmail.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox