Util-Linux package development
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Jeffrey Bastian <jbastian@redhat.com>
Cc: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>,
	util-linux@vger.kernel.org,
	Shunsuke Nakamura <nakamura.shun@fujitsu.com>
Subject: Re: [PATCH] lscpu: Add FUJITSU aarch64 A64FX cpupart
Date: Wed, 30 Sep 2020 19:40:27 +0200	[thread overview]
Message-ID: <20200930174027.rohdyp2kubitbs24@ws.net.home> (raw)
In-Reply-To: <20200930144409.e5agryctsfijrrrb@tarantula.users.ipa.redhat.com>

On Wed, Sep 30, 2020 at 09:44:09AM -0500, Jeffrey Bastian wrote:
> On Tue, Sep 29, 2020 at 12:46:27PM +0200, Karel Zak wrote:
> > On Mon, Sep 28, 2020 at 06:46:14PM +0900, Shunsuke Nakamura wrote:
> > >  sys-utils/lscpu-arm.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > 
> > Applied, thanks.
> 
> 
> With the other ARM patch applied ("use SMBIOS tables on ARM for lscpu"),
> the output changes on an FX700 system:
> 
> [root@fujitsu-fx700 ~]# ./lscpu | grep -e Vendor -e Model -e Stepping
> Vendor ID:                       FUJITSU
> Model:                           0
> Model name:                      461F0010
> Stepping:                        0x1
> 
> 
> The values here come from the SMBIOS Type 4 record:
> 
> [root@fujitsu-fx700 ~]# strings /sys/firmware/dmi/entries/4-0/raw
> CPU1
> FUJITSU
> 461F0010
> 8K083MH14
> 
> 
> This FX700 system has firmware revision 1.4.0 (Jun 17 2020).

hmm... 461F0010 does not seem user-friendly, "A64FX" seems better. 

Shunsuke, what about to update the firmware strings? ;-) (as Jeffrey
suggested in RH bugzilla)

The another possibility is to exclude some vendors and do not use
SMBIOS for them (e.g. 0x46 for Fujitsu), but from my point of view
SMBIOS based solution is more elegant and ready for new CPU types than
in-lscpu hard coded tables.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


  reply	other threads:[~2020-09-30 17:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  9:46 [PATCH] lscpu: Add FUJITSU aarch64 A64FX cpupart Shunsuke Nakamura
2020-09-29 10:46 ` Karel Zak
2020-09-30 14:44   ` Jeffrey Bastian
2020-09-30 17:40     ` Karel Zak [this message]
2020-09-30 18:49       ` Masayoshi Mizuma
2020-09-30 21:53         ` Jeffrey Bastian
2020-10-01  3:05           ` Masayoshi Mizuma
2020-10-02 12:15             ` nakamura.shun
2020-10-05 13:35               ` Jeffrey Bastian
2020-10-08 12:10                 ` Masayoshi Mizuma
2020-10-15 18:53                   ` Jeffrey Bastian
2020-10-19 18:55                     ` Masayoshi Mizuma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930174027.rohdyp2kubitbs24@ws.net.home \
    --to=kzak@redhat.com \
    --cc=jbastian@redhat.com \
    --cc=nakamura.shun@fujitsu.com \
    --cc=nakamura.shun@jp.fujitsu.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox