Util-Linux package development
 help / color / mirror / Atom feed
From: Karel Zak <kzak@redhat.com>
To: Huang Shijie <shijie@os.amperecomputing.com>
Cc: util-linux@vger.kernel.org, patches@amperecomputing.com,
	zwang@amperecomputing.com, mas@amperecomputing.com,
	ilkka@os.amperecomputing.com, jeremy.linton@arm.com,
	jbastian@redhat.com, m.mizuma@jp.fujitsu.com,
	patrick.zhang@amperecomputing.com
Subject: Re: [RFC PATCH] lscpu: get more infomation when using "/sys/firmware/dmi/entries/4-0/raw"
Date: Fri, 25 Jun 2021 13:28:11 +0200	[thread overview]
Message-ID: <20210625112811.lf2eztyp42jdpssf@ws.net.home> (raw)
In-Reply-To: <YNWi14N4DToDMlUa@hsj-NUC11PAHi7>

On Fri, Jun 25, 2021 at 05:33:11PM +0800, Huang Shijie wrote:
> Hi Karel,
> On Fri, Jun 25, 2021 at 11:23:01AM +0200, Karel Zak wrote:
> > 
> > I've lost in your patches :-) 
> > 
> > Your previous patch "[PATCH] lscpu: remove the old code" removes all
> > arm_smbios_decode() as it's unnecessary. This next patch tries to
> > extend arm_smbios_decode().
> I thought you do not like the patch "[PATCH] lscpu: remove the old code".

If I don't like anything then I provide feedback, ignore contributors
in silent way is not polite from my point of view ;-)

I've thought that jbastian and m.mizuma will provide any feedback
about /sys/firmware/dmi/entries/4-0/raw removal from lscpu.

> It is okay that any patch of the two is merged. :)

OK, removed code is a good code. So it seems the first patch is
probably a good idea.

  Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com


      reply	other threads:[~2021-06-25 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 11:09 [RFC PATCH] lscpu: get more infomation when using "/sys/firmware/dmi/entries/4-0/raw" Huang Shijie
2021-06-25  9:23 ` Karel Zak
2021-06-25  9:33   ` Huang Shijie
2021-06-25 11:28     ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625112811.lf2eztyp42jdpssf@ws.net.home \
    --to=kzak@redhat.com \
    --cc=ilkka@os.amperecomputing.com \
    --cc=jbastian@redhat.com \
    --cc=jeremy.linton@arm.com \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=mas@amperecomputing.com \
    --cc=patches@amperecomputing.com \
    --cc=patrick.zhang@amperecomputing.com \
    --cc=shijie@os.amperecomputing.com \
    --cc=util-linux@vger.kernel.org \
    --cc=zwang@amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox