Util-Linux package development
 help / color / mirror / Atom feed
From: Enze Li <lienze@kylinos.cn>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] build-sys: add blkpr to gitignore
Date: Fri, 15 Apr 2022 14:01:52 +0800	[thread overview]
Message-ID: <20220415140152.4fe3d03c@ubuntu> (raw)
In-Reply-To: <6f22345a-8351-ae01-7df2-c2d31ccd5956@bytedance.com>

On Fri, 15 Apr 2022 11:31:31 +0800
zhenwei pi <pizhenwei@bytedance.com> wrote:

> On 4/15/22 11:31, Enze Li wrote:
> > Since this commit 627428a95692 ("blkpr: add block persistent
> > reservations command"), we introduced blkpr, but the compiled
> > generated binary file is not added to the gitignore, so let's do it.
> > 
> > Signed-off-by: Enze Li <lienze@kylinos.cn>
> > ---
> >   .gitignore | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/.gitignore b/.gitignore
> > index 3274563ec..0effa8945 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -73,6 +73,7 @@ GSYMS
> >   /addpart
> >   /agetty
> >   /blkdiscard
> > +/blkpr
> >   /blkzone
> >   /blkid
> >   /blockdev  

Hi zhenwei,

Thanks for your review.

> 
> Could you please reorder blkXX together to make them all in order?
> 

Indeed, if this is necessary.  I've sent v2 to util-liux@list.

Thanks,
Enze

  reply	other threads:[~2022-04-15  6:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15  3:31 [PATCH] build-sys: add blkpr to gitignore Enze Li
2022-04-15  3:31 ` zhenwei pi
2022-04-15  6:01   ` Enze Li [this message]
2022-04-15  5:55 ` [PATCH v2] " Enze Li
2022-04-19  9:52   ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220415140152.4fe3d03c@ubuntu \
    --to=lienze@kylinos.cn \
    --cc=pizhenwei@bytedance.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox