From: Benno Schulenberg <bensberg@telfort.nl>
To: util-linux@vger.kernel.org
Subject: [PATCH 09/14] blkpr: grammarize the description of the tool and its options
Date: Sun, 9 Feb 2025 09:23:25 +0100 [thread overview]
Message-ID: <20250209082330.4235-9-bensberg@telfort.nl> (raw)
In-Reply-To: <20250209082330.4235-1-bensberg@telfort.nl>
Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>
---
sys-utils/blkpr.8.adoc | 9 +++++----
sys-utils/blkpr.c | 14 +++++++-------
2 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/sys-utils/blkpr.8.adoc b/sys-utils/blkpr.8.adoc
index 0f71bd0f0..db2b8a0a9 100644
--- a/sys-utils/blkpr.8.adoc
+++ b/sys-utils/blkpr.8.adoc
@@ -8,7 +8,7 @@
== NAME
-blkpr - run persistent reservations command on a device
+blkpr - run a persistent-reservations command on a device
== SYNOPSIS
@@ -16,15 +16,16 @@ blkpr - run persistent reservations command on a device
== DESCRIPTION
-*blkpr* is used to run persistent reservations command on device that supports Persistent Reservations feature.
+*blkpr* is used to run a persistent-reservations command on a device
+that supports the Persistent Reservations feature.
The _device_ argument is the pathname of the block device.
== OPTIONS
*-c*, *--command* _command_::
-The command of persistent reservations, supported commands are *register*, *reserve*, *release*, *preempt*,
-*preempt-abort*, and *clear*.
+The command for managing persistent reservations. Supported commands are:
+*register*, *reserve*, *release*, *preempt*, *preempt-abort*, and *clear*.
*-k*, *--key* _key_::
The key the command should operate on.
diff --git a/sys-utils/blkpr.c b/sys-utils/blkpr.c
index 7f88eba50..03ca9f7e5 100644
--- a/sys-utils/blkpr.c
+++ b/sys-utils/blkpr.c
@@ -213,12 +213,12 @@ static void __attribute__((__noreturn__)) usage(void)
_(" %s [options] <device>\n"), program_invocation_short_name);
fputs(USAGE_SEPARATOR, out);
- fputs(_("Persistent reservations on a device.\n"), out);
+ fputs(_("Manage persistent reservations on a device.\n"), out);
fputs(USAGE_OPTIONS, out);
- fputs(_(" -c, --command <cmd> command of persistent reservations\n"), out);
- fputs(_(" -k, --key <num> key to operate\n"), out);
- fputs(_(" -K, --oldkey <num> old key to operate\n"), out);
+ fputs(_(" -c, --command <cmd> command for persistent reservations\n"), out);
+ fputs(_(" -k, --key <num> key to operate on\n"), out);
+ fputs(_(" -K, --oldkey <num> old key to operate on\n"), out);
fputs(_(" -f, --flag <flag> command flag\n"), out);
fputs(_(" -t, --type <type> command type\n"), out);
@@ -227,13 +227,13 @@ static void __attribute__((__noreturn__)) usage(void)
fputs(USAGE_ARGUMENTS, out);
- fputs(_(" <cmd> is an command, available command:\n"), out);
+ fputs(_(" <cmd> is a command; available commands are:\n"), out);
print_pr_command(out);
- fputs(_(" <flag> is a command flag, available flags:\n"), out);
+ fputs(_(" <flag> is a command flag; available flags are:\n"), out);
print_pr_flag(out);
- fputs(_(" <type> is a command type, available types:\n"), out);
+ fputs(_(" <type> is a command type; available types are:\n"), out);
print_pr_type(out);
fprintf(out, USAGE_MAN_TAIL("blkpr(8)"));
--
2.48.1
next prev parent reply other threads:[~2025-02-09 8:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 8:23 [PATCH 01/14] setpriv: make message for failing PR_GET_PDEATHSIG the same as the other Benno Schulenberg
2025-02-09 8:23 ` [PATCH 02/14] unshare: don't use "=" before a required option argument Benno Schulenberg
2025-02-09 8:23 ` [PATCH 03/14] unshare: use single asterisks around long options, double around values Benno Schulenberg
2025-02-09 8:23 ` [PATCH 04/14] textual: remove other inconsistent uses of "=" before option argument Benno Schulenberg
2025-02-09 8:23 ` [PATCH 05/14] textual: consistently mark "=" as literal before an optional argument Benno Schulenberg
2025-02-09 8:23 ` [PATCH 06/14] mount: properly mark the arguments of the 'ro' and 'rw' extended options Benno Schulenberg
2025-02-09 8:23 ` [PATCH 07/14] unshare: don't mark "|" and ":" as part of the placeholders Benno Schulenberg
2025-02-09 8:23 ` [PATCH 08/14] textual: give seven error messages the same form as two others Benno Schulenberg
2025-02-09 8:23 ` Benno Schulenberg [this message]
2025-02-09 8:23 ` [PATCH 10/14] blkzone: correct the wording of an error message, from ioctl to function Benno Schulenberg
2025-02-10 11:28 ` Karel Zak
2025-02-09 8:23 ` [PATCH 11/14] renice: put text that belongs together into a single translatable message Benno Schulenberg
2025-02-09 8:23 ` [PATCH 12/14] man pages: use the same verb for --version as for --help, like in usages Benno Schulenberg
2025-02-09 8:23 ` [PATCH 13/14] usage: mention also the missing KiB and MiB as permissible suffixes Benno Schulenberg
2025-02-09 8:23 ` [PATCH 14/14] zramctl: improve grammar in usage and don't gettextize list of algorithms Benno Schulenberg
2025-02-12 10:01 ` [PATCH 01/14] setpriv: make message for failing PR_GET_PDEATHSIG the same as the other Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250209082330.4235-9-bensberg@telfort.nl \
--to=bensberg@telfort.nl \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox