From: Benno Schulenberg <bensberg@telfort.nl>
To: util-linux@vger.kernel.org
Cc: LiviaMedeiros <livia@cirno.name>
Subject: [PATCH 3/4] zramctl: restore normal description indentations in the usage text
Date: Sun, 6 Apr 2025 17:21:46 +0200 [thread overview]
Message-ID: <20250406152147.9225-3-bensberg@telfort.nl> (raw)
In-Reply-To: <20250406152147.9225-1-bensberg@telfort.nl>
Commit 19c12e63b1 from four months ago changed the indentation of *all*
the option descriptions in the usage text. That was the wrong thing to
do, as it invalidates all existing translations for no good reason.
When one of the options is (or needs to become) overlong, then the thing
to do is: to put the description of this option on the next line.
So, restore the indentation of the descriptions to what they were
before commit 19c12e63b1, and wrap the description of -p.
Also, make the description of -b fit within 80 columns, and sort the
options better: alphabetically, but single letter before long option.
CC: LiviaMedeiros <livia@cirno.name>
Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>
---
sys-utils/zramctl.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/sys-utils/zramctl.c b/sys-utils/zramctl.c
index 36cc55ff9..b9ea5998e 100644
--- a/sys-utils/zramctl.c
+++ b/sys-utils/zramctl.c
@@ -745,17 +745,18 @@ static void __attribute__((__noreturn__)) usage(void)
fputs(_("Set up and control zram devices.\n"), out);
fputs(USAGE_OPTIONS, out);
- fputs(_(" -a, --algorithm <alg> compression algorithm to use\n"), out);
- fputs(_(" -b, --bytes print sizes in bytes rather than in human readable format\n"), out);
- fputs(_(" -f, --find find a free device\n"), out);
- fputs(_(" -n, --noheadings don't print headings\n"), out);
- fputs(_(" -o, --output <list> columns to use for status output\n"), out);
- fputs(_(" --output-all output all columns\n"), out);
- fputs(_(" -p, --algorithm-params <params> algorithm parameters to use\n"), out);
- fputs(_(" --raw use raw status output format\n"), out);
- fputs(_(" -r, --reset reset all specified devices\n"), out);
- fputs(_(" -s, --size <size> device size\n"), out);
- fputs(_(" -t, --streams <number> number of compression streams\n"), out);
+ fputs(_(" -a, --algorithm <alg> compression algorithm to use\n"), out);
+ fputs(_(" -b, --bytes print sizes in bytes, not in human-readable form\n"), out);
+ fputs(_(" -f, --find find a free device\n"), out);
+ fputs(_(" -n, --noheadings don't print headings\n"), out);
+ fputs(_(" -o, --output <list> columns to use for status output\n"), out);
+ fputs(_(" --output-all output all columns\n"), out);
+ fputs(_(" -p, --algorithm-params <parameters>\n"
+ " parameters for the compression algorithm\n"), out);
+ fputs(_(" -r, --reset reset all specified devices\n"), out);
+ fputs(_(" --raw use raw status output format\n"), out);
+ fputs(_(" -s, --size <size> device size\n"), out);
+ fputs(_(" -t, --streams <number> number of compression streams\n"), out);
fputs(USAGE_SEPARATOR, out);
fprintf(out, USAGE_HELP_OPTIONS(27));
--
2.48.1
next prev parent reply other threads:[~2025-04-06 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 15:21 [PATCH 1/4] hwclock: remove two comments about parameters that no longer exist Benno Schulenberg
2025-04-06 15:21 ` [PATCH 2/4] textual: fix a mistruncated message, and fix a typo Benno Schulenberg
2025-04-06 15:21 ` Benno Schulenberg [this message]
2025-04-06 15:21 ` [PATCH 4/4] zramctl: (man) mention the required arguments for -p and -r Benno Schulenberg
2025-04-08 11:44 ` [PATCH 1/4] hwclock: remove two comments about parameters that no longer exist Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250406152147.9225-3-bensberg@telfort.nl \
--to=bensberg@telfort.nl \
--cc=livia@cirno.name \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox