From: Benno Schulenberg <bensberg@telfort.nl>
To: util-linux@vger.kernel.org
Cc: Nathan Sharp <nwsharp@live.com>
Subject: [PATCH 6/7] pipesz: report default size in --help, instead of referring the user
Date: Thu, 24 Apr 2025 11:32:36 +0200 [thread overview]
Message-ID: <20250424093237.6432-6-bensberg@telfort.nl> (raw)
In-Reply-To: <20250424093237.6432-1-bensberg@telfort.nl>
The man page says where this default size can be found. In the --help
text it is more useful to directly say what this default size is.
CC: Nathan Sharp <nwsharp@live.com>
Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>
---
misc-utils/pipesz.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/misc-utils/pipesz.c b/misc-utils/pipesz.c
index 48f07aed7..c317959e4 100644
--- a/misc-utils/pipesz.c
+++ b/misc-utils/pipesz.c
@@ -71,11 +71,8 @@ static void __attribute__((__noreturn__)) usage(void)
fputs(USAGE_OPTIONS, stdout);
fputsln(_(" -g, --get examine pipe buffers"), stdout);
- /* TRANSLATORS: '%s' refers to a system file */
fprintf(stdout,
- _(" -s, --set <size> set pipe buffer sizes\n"
- " size defaults to %s\n"),
- PIPESZ_DEFAULT_SIZE_FILE);
+ _(" -s, --set <size> the buffer size to be used (default: %u)\n"), opt_size);
fputs(USAGE_SEPARATOR, stdout);
fputsln(_(" -f, --file <path> act on a file"), stdout);
@@ -232,6 +229,8 @@ int main(int argc, char **argv)
while ((c = getopt_long(argc, argv, shortopts, longopts, NULL)) != -1) {
switch (c) {
case 'h':
+ if (ul_path_read_s32(NULL, &opt_size, PIPESZ_DEFAULT_SIZE_FILE))
+ warn(_("cannot parse %s"), PIPESZ_DEFAULT_SIZE_FILE);
usage();
case 'V':
print_version(EXIT_SUCCESS);
--
2.48.1
next prev parent reply other threads:[~2025-04-24 9:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 9:32 [PATCH 1/7] unshare: make the wording of a message identical to that of three others Benno Schulenberg
2025-04-24 9:32 ` [PATCH 2/7] irqtop: make the wording of an error message identical to that of another Benno Schulenberg
2025-04-24 9:32 ` [PATCH 3/7] lsfd: improve grammar, and use angular brackets around placeholder word Benno Schulenberg
2025-04-24 9:55 ` Masatake YAMATO
2025-04-24 10:05 ` Karel Zak
2025-04-25 10:36 ` Benno Schulenberg
2025-04-29 19:54 ` Masatake YAMATO
2025-04-30 8:20 ` Benno Schulenberg
2025-04-24 9:32 ` [PATCH 4/7] docs,usage: harmonize description of --hyperlink, and add 2 missing ones Benno Schulenberg
2025-04-24 10:08 ` Karel Zak
2025-04-25 10:43 ` Benno Schulenberg
2025-04-25 20:07 ` Karel Zak
2025-04-24 9:32 ` [PATCH 5/7] pipesz: (man) improve the markup and some wordings Benno Schulenberg
2025-04-24 9:32 ` Benno Schulenberg [this message]
2025-04-24 11:28 ` [PATCH 6/7] pipesz: report default size in --help, instead of referring the user Nathan Sharp
[not found] ` <MN0P221MB1530A6F07A44AF169879CBA7C2852@MN0P221MB1530.NAMP221.PROD.OUTLOOK.COM>
2025-04-24 13:15 ` Benno Schulenberg
2025-04-24 9:32 ` [PATCH 7/7] uuidd: put an option and its description in a single message Benno Schulenberg
2025-04-29 11:11 ` [PATCH 1/7] unshare: make the wording of a message identical to that of three others Karel Zak
2025-04-29 13:55 ` Benno Schulenberg
2025-04-30 11:18 ` Karel Zak
2025-04-30 11:19 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424093237.6432-6-bensberg@telfort.nl \
--to=bensberg@telfort.nl \
--cc=nwsharp@live.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox