Util-Linux package development
 help / color / mirror / Atom feed
From: Benno Schulenberg <bensberg@telfort.nl>
To: util-linux@vger.kernel.org
Subject: [PATCH 3/4] hardlink: (usage) improve the descriptions of three options
Date: Fri, 23 May 2025 14:04:06 +0200	[thread overview]
Message-ID: <20250523120407.75188-3-bensberg@telfort.nl> (raw)
In-Reply-To: <20250523120407.75188-1-bensberg@telfort.nl>

The first description was too wordy for a --help text, the second
was vague and seemed to imply that it should be combined with the
preceding option, and the third failed to mention that it doesn't
actually link anything.

(Note: the choice for -m for --maximize and -M for --minimize is
unfortunate, as most people would guess the opposite, especially
since -s is used for --minimum-size and -S for --maximum-size.)

Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>
---
 misc-utils/hardlink.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/misc-utils/hardlink.c b/misc-utils/hardlink.c
index 7f2ff8046..5365e5370 100644
--- a/misc-utils/hardlink.c
+++ b/misc-utils/hardlink.c
@@ -1195,11 +1195,10 @@ static void __attribute__((__noreturn__)) usage(void)
 	fputs(_(" -d, --respect-dir          directory names have to be identical\n"), out);
 	fputs(_(" -f, --respect-name         filenames have to be identical\n"), out);
 	fputs(_(" -i, --include <regex>      regular expression to include files/dirs\n"), out);
-	fputs(_(" -m, --maximize             maximize the hardlink count, remove the file with\n"
-	        "                              lowest hardlink count\n"), out);
-	fputs(_(" -M, --minimize             reverse the meaning of -m\n"), out);
+	fputs(_(" -m, --maximize             keep the file with the most links\n"), out);
+	fputs(_(" -M, --minimize             keep the file with the fewest links\n"), out);
 	fputs(_(" -n, --dry-run              don't actually link anything\n"), out);
-	fputs(_(" -l, --list-duplicates      print every group of duplicate files\n"), out);
+	fputs(_(" -l, --list-duplicates      just list paths of duplicates, don't link them\n"), out);
 	fputs(_(" -z, --zero                 delimit output with NULs instead of newlines\n"), out);
 	fputs(_(" -o, --ignore-owner         ignore owner changes\n"), out);
 	fputs(_(" -F, --prioritize-trees     files found in the earliest specified top-level\n"
-- 
2.48.1


  parent reply	other threads:[~2025-05-23 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-23 12:04 [PATCH 1/4] hexdump: (man) put a list item on a single line, to avoid a warning Benno Schulenberg
2025-05-23 12:04 ` [PATCH 2/4] hardlink: (usage) remove mistaken period from two option descriptions Benno Schulenberg
2025-05-23 12:04 ` Benno Schulenberg [this message]
2025-05-26 17:30   ` [PATCH 3/4] hardlink: (usage) improve the descriptions of three options Karel Zak
2025-05-23 12:04 ` [PATCH 4/4] hardlink: (man,usage) sort the options mostly alphabetically Benno Schulenberg
2025-05-29 11:45 ` [PATCH 1/4] hexdump: (man) put a list item on a single line, to avoid a warning Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250523120407.75188-3-bensberg@telfort.nl \
    --to=bensberg@telfort.nl \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox