public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Kiran Rangoon <kiranrangoon0@gmail.com>
To: util-linux@vger.kernel.org
Cc: thomas@t-8ch.de, Kiran Rangoon <kiranrangoon0@gmail.com>
Subject: [PATCH v4 2/4] libuuid: refactor gregorian_to_unix to populate timeval directly
Date: Tue, 23 Dec 2025 13:00:53 -0500	[thread overview]
Message-ID: <20251223180055.2396-3-kiranrangoon0@gmail.com> (raw)
In-Reply-To: <20251223180055.2396-1-kiranrangoon0@gmail.com>

Change function signature to take struct timeval pointer and populate
it directly, eliminating duplicate conversion code in callers.

Signed-off-by: Kiran Rangoon <kiranrangoon0@gmail.com>
---
 libuuid/src/uuid_time.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/libuuid/src/uuid_time.c b/libuuid/src/uuid_time.c
index e2b991d74..2f7c6652c 100644
--- a/libuuid/src/uuid_time.c
+++ b/libuuid/src/uuid_time.c
@@ -60,10 +60,12 @@
 /* prototype to make compiler happy */
 time_t __uuid_time(const uuid_t uu, struct timeval *ret_tv);
 
-static uint64_t gregorian_to_unix(uint64_t ts)
+static void gregorian_to_unix(uint64_t ts, struct timeval *tv)
 {
 	const uint64_t offset = 0x01B21DD213814000ULL;
-	return ts - offset;
+	uint64_t clock_reg = ts - offset;
+	tv->tv_sec = clock_reg / 10000000;
+	tv->tv_usec = (clock_reg % 10000000) / 10;
 }
 
 static void uuid_time_v1(const struct uuid *uuid, struct timeval *tv)
@@ -74,9 +76,7 @@ static void uuid_time_v1(const struct uuid *uuid, struct timeval *tv)
 	high = uuid->time_mid | ((uuid->time_hi_and_version & 0xFFF) << 16);
 	clock_reg = uuid->time_low | ((uint64_t) high << 32);
 
-	clock_reg = gregorian_to_unix(clock_reg);
-	tv->tv_sec = clock_reg / 10000000;
-	tv->tv_usec = (clock_reg % 10000000) / 10;
+	gregorian_to_unix(clock_reg, tv);
 }
 
 static void uuid_time_v6(const struct uuid *uuid, struct timeval *tv)
@@ -89,9 +89,7 @@ static void uuid_time_v6(const struct uuid *uuid, struct timeval *tv)
 	clock_reg <<= 12;
 	clock_reg |= uuid->time_hi_and_version & 0xFFF;
 
-	clock_reg = gregorian_to_unix(clock_reg);
-	tv->tv_sec = clock_reg / 10000000;
-	tv->tv_usec = (clock_reg % 10000000) / 10;
+	gregorian_to_unix(clock_reg, tv);
 }
 
 static void uuid_time_v7(const struct uuid *uuid, struct timeval *tv)
-- 
2.47.3


  parent reply	other threads:[~2025-12-23 18:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-13 20:04 [PATCH] libuuid: Fix pre-1970 UUID v1 timestamp wraparound Kiran Rangoon
2025-12-13 23:36 ` Thomas Weißschuh 
2025-12-14  1:01 ` [PATCH v2] " Kiran Rangoon
2025-12-16 13:08   ` Thomas Weißschuh
2025-12-16 20:40     ` Kiran
2025-12-16 23:21       ` Thomas Weißschuh
2025-12-17 20:42         ` [PATCH v3 1/2] libuuid: Refactor UUID time conversion for pre-epoch dates Kiran Rangoon
2025-12-17 20:59         ` Kiran Rangoon
2025-12-18 21:31         ` Kiran Rangoon
2025-12-19 11:40           ` Thomas Weißschuh
2025-12-23 18:00             ` [PATCH v4 0/4] libuuid: Fix pre-1970 UUID timestamp overflow Kiran Rangoon
2025-12-23 18:00               ` [PATCH v4 1/4] libuuid: simplify gregorian-to-unix offset calculation Kiran Rangoon
2025-12-23 18:00               ` Kiran Rangoon [this message]
2025-12-23 18:03               ` Kiran Rangoon
2025-12-23 18:22               ` [PATCH v4 0/4] libuuid: Fix pre-1970 UUID timestamp overflow Thomas Weißschuh 
2025-12-28  8:47               ` Thomas Weißschuh
2025-12-23 18:04             ` [PATCH v4 3/4] libuuid: fix timestamp overflow for pre-1970 dates Kiran Rangoon
2025-12-23 18:05             ` [PATCH v4 4/4] tests: correct UUID timestamp test expectations Kiran Rangoon
2025-12-17 11:01   ` [PATCH v2] libuuid: Fix pre-1970 UUID v1 timestamp wraparound Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251223180055.2396-3-kiranrangoon0@gmail.com \
    --to=kiranrangoon0@gmail.com \
    --cc=thomas@t-8ch.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox