util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bernhard Voelker <mail@bernhard-voelker.de>
To: util-linux@vger.kernel.org
Subject: [PATCH 04/15] prlimit: add warning diagnostic when attempting to change prlimit's limits
Date: Mon, 14 Nov 2011 02:48:11 +0100	[thread overview]
Message-ID: <4EC0735B.2010504@bernhard-voelker.de> (raw)

[PATCH 04/15] prlimit: add warning diagnostic when attempting to change 
prlimit's limits

Setting the limits of the prlimit process is useless because it will
exit shortly anyway. To help the user not to fall into this trap,
prlimit now displays a warning.

Signed-off-by: Bernhard Voelker <mail@bernhard-voelker.de>
---
  sys-utils/prlimit.c |    7 +++++--
  1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/sys-utils/prlimit.c b/sys-utils/prlimit.c
index 6943d11..9a52b81 100644
--- a/sys-utils/prlimit.c
+++ b/sys-utils/prlimit.c
@@ -302,10 +302,13 @@ static void do_prlimit(struct prlimit lims[], 
size_t n, int tt_flags)
  	for (i = 0; i < n; i++) {
  		struct rlimit *new = NULL;

-		if (lims[i].modify)
+		if (lims[i].modify) {
+			if (!pid)
+				warnx(_("setting limits of the prlimit process is pointless"));
  			new = &lims[i].rlim;
-		else
+		} else {
  			nshows++;
+		}

  		if (verbose && new) {
  			printf(_("New %s limit: "), lims[i].desc->name);

             reply	other threads:[~2011-11-14  1:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14  1:48 Bernhard Voelker [this message]
2011-11-16 12:45 ` [PATCH 04/15] prlimit: add warning diagnostic when attempting to change prlimit's limits Karel Zak
2011-11-16 15:05   ` Bernhard Voelker
2011-11-16 15:55     ` Karel Zak
2011-11-16 15:05   ` Bernhard Voelker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EC0735B.2010504@bernhard-voelker.de \
    --to=mail@bernhard-voelker.de \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).