From: Bernhard Voelker <mail@bernhard-voelker.de>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 04/15] prlimit: add warning diagnostic when attempting to change prlimit's limits
Date: Wed, 16 Nov 2011 16:05:17 +0100 [thread overview]
Message-ID: <4EC3D12D.8090708@bernhard-voelker.de> (raw)
In-Reply-To: <20111116124537.GD7916@nb.net.home>
On 11/16/2011 01:45 PM, Karel Zak wrote:
> On Mon, Nov 14, 2011 at 02:48:11AM +0100, Bernhard Voelker wrote:
>> > + if (lims[i].modify) {
>> > + if (!pid)
>> > + warnx(_("setting limits of the prlimit process is pointless"));
>
> Well, I don't think that we want such warnings in our utils:-) Let's
> inform users about errors, the rest should be described in man pages.
hmm, then I tend to make it an error: prlimit acts too similar to
ulimit, but the *big* difference - and therefore the *big* trap for
the user - is that ulimit is a shell builtin which affects the current
shell process whereas prlimit runs in it's own process and, as a result,
will just do not have an effect without a PID.
Have a nice day,
Berny
prev parent reply other threads:[~2011-11-16 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 1:48 [PATCH 04/15] prlimit: add warning diagnostic when attempting to change prlimit's limits Bernhard Voelker
2011-11-16 12:45 ` Karel Zak
2011-11-16 15:05 ` Bernhard Voelker
2011-11-16 15:55 ` Karel Zak
2011-11-16 15:05 ` Bernhard Voelker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC3D12D.8090708@bernhard-voelker.de \
--to=mail@bernhard-voelker.de \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).