From: "gnehzuil.lzheng@gmail.com" <gnehzuil.lzheng@gmail.com>
To: Bernhard Voelker <mail@bernhard-voelker.de>
Cc: Jens Axboe <axboe@kernel.dk>, Rob Landley <rob@landley.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
util-linux@vger.kernel.org
Subject: Re: Why does ionice(1) ban the user to set back to 'none' class?
Date: Tue, 19 Jun 2012 16:15:53 +0800 [thread overview]
Message-ID: <4FE03539.7060005@gmail.com> (raw)
In-Reply-To: <4FE01ED8.8000903@bernhard-voelker.de>
On 06/19/2012 02:40 PM, Bernhard Voelker wrote:
> That has already been fixed by commit v2.15-45-g5dc9371 more than 2 years ago:
>
> Author: Jakob Unterwurzacher <jakobunt@gmail.com> 2009-01-17 02:38:32
> Committer: Karel Zak <kzak@redhat.com> 2009-05-27 23:43:18
>
> and the change made it into 2.16.
>
> The current piece of code looks like this:
>
> switch (ioclass) {
> case IOPRIO_CLASS_NONE:
> if ((set & 1) && !tolerant)
> warnx(_("ignoring given class data for none class"));
> data = 0;
> break;
> case IOPRIO_CLASS_RT:
> case IOPRIO_CLASS_BE:
> break;
>
> We'are currently at version 2.21.2.
Thanks for pointing out it. I use ionice(1) in rhel5 and its version is
2.13. :-p
Obviously, Documentation/block/ioprio.txt is out of date. Later I will
send a patch to fix it.
Regards,
Zheng
prev parent reply other threads:[~2012-06-19 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120618114841.GA4855@gmail.com>
[not found] ` <4FDF2D10.9050008@kernel.dk>
2012-06-19 2:11 ` Why does ionice(1) ban the user to set back to 'none' class? gnehzuil.lzheng
2012-06-19 6:40 ` Bernhard Voelker
2012-06-19 8:15 ` gnehzuil.lzheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE03539.7060005@gmail.com \
--to=gnehzuil.lzheng@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@bernhard-voelker.de \
--cc=rob@landley.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).