util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: J William Piggott <elseifthen@gmx.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/4] pull request
Date: Mon, 26 Jun 2017 09:47:42 -0400	[thread overview]
Message-ID: <4aaa7de1-b06c-331c-55fe-2cadcdcee87b@gmx.com> (raw)
In-Reply-To: <20170626082744.fx4zzuq4sgpzdkk6@ws.net.home>



On 06/26/2017 04:27 AM, Karel Zak wrote:
> On Sun, Jun 25, 2017 at 05:45:56PM -0400, J William Piggott wrote:
>>
>> * Rudi didn't like cluttering boilerplate.c with seldom used USAGE_*
>>   constants and I don't disagree with that point. I do think they should
>>   be in the file for new contributor discovery purposes. As a compromise
>>   I added the missing ones as a comment.
>>
>> * the newly added USAGE_COLUMNS could be used in disk-utils/fdisk-list.c:432
>>   if Karel wants to drop the ' (for -o)'. I did not change it.
> 
> I think USAGE_COLUMNS should be good enough everywhere and the
> additional notes (like ' (for -o)') are unnecessary.
> 
> Maybe we can change the text to "Available output columns:" to make it
> more specific for readers.

Since we cannot guarantee that the 'output' option name will always be
available. It might be better to stay generic with the header and
instead create the reference in the option description like:

 -o, --output <list>    columns to display (see Columns:)

 Columns:
      SOURCE  source device
      ...

This would also keep the Columns header format consistent with the others.

On a somewhat related note; in recent discussion I've been trying to
promote the idea of using consistent language. For example, with all of
the synonyms: output, show, to stdout, display, print, etc. I think it
would be helpful to both users and translators to choose one to be used
consistently. Especially for technical writing it is important to use
consistent terms.

An idea from the Linux man-pages project is that man-pages.7 has a list
of preferred terms/spellings; perhaps util-linux could have a list of
preferred terms to be used in documentation and message strings?

We also might want to consider replacing Documentation/howto-man-page.txt
with a link to, or a copy of, man-pages.7. Michael and company have
added a lot to it in recent times.


> 
>     Karel
> 
> 

  parent reply	other threads:[~2017-06-26 13:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-25 21:45 [PATCH 0/4] pull request J William Piggott
2017-06-25 21:47 ` [PATCH 1/4] include/c.h: add USAGE_COMMANDS and USAGE_COLUMNS J William Piggott
2017-06-25 21:49 ` [PATCH 2/4] Docs: add a comment for constants to boilerplate.c J William Piggott
2017-06-25 21:50 ` [PATCH 3/4] Docs: update howto-usage-function.txt J William Piggott
2017-06-25 21:51 ` [PATCH 4/4] Docs: move option naming to howto-contribute.txt J William Piggott
2017-06-26  8:27 ` [PATCH 0/4] pull request Karel Zak
2017-06-26 12:11   ` Karel Zak
2017-06-26 13:47   ` J William Piggott [this message]
2017-06-26 14:25     ` Karel Zak
  -- strict thread matches above, loose matches on Subject: below --
2017-12-10 15:47 [PATCH 0/4] Pull Request J William Piggott
2017-12-11 14:53 ` Karel Zak
2017-10-23  0:37 J William Piggott
2017-07-16 17:46 J William Piggott
2017-07-17 10:03 ` Karel Zak
2017-05-31 18:45 [PATCH 0/4] pull request J William Piggott
2017-06-01  8:54 ` Karel Zak
2017-04-27  3:29 [PATCH 0/4] Pull Request J William Piggott
2017-05-02  9:13 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aaa7de1-b06c-331c-55fe-2cadcdcee87b@gmx.com \
    --to=elseifthen@gmx.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).