Re: [RFC] mount: overwrite options from /etc/fstab when given on the commandline

[Niels de Vos <ndevos@redhat.com>]

On 08/01/2012 12:32 PM, Karel Zak wrote:
> On Wed, Aug 01, 2012 at 12:14:22PM +0200, Niels de Vos wrote:
>> On 08/01/2012 12:03 PM, Karel Zak wrote:
>>> On Wed, Aug 01, 2012 at 11:48:33AM +0200, Karel Zak wrote:
>>>>> Some options are not allowed to be
>>>>> passed multiple times (like the SElinux context options) and mounting will fail
>>>>> if options are present in both /etc/fstab and on the commandline.
>>>>
>>>> This is stupid SELinux disadvantage and SELinux should be fixed.
>>>
>>> Note that mount(8) and libmount removes all selinux context options on
>>> remount for kernels<   2.6.39 because SELinux context remount was
>>> unsupported, so this SELinux disadvantage should be hidden for usual
>>> use case.
>>>
>>> Maybe we can also add another exception for SELinux to de-duplicate
>>> the SELinux context options in the options string. It's not perfect,
>>> but probably acceptable for SELinux -- I can do this for 2.22-rc2.
>>
>> That would be great. What is your opinion on getting the SElinux options
>> handled differently in the kernel instead or in addition?
>
> SELinux is no filesystem and we already have (must have) SELinux
> specific code in mount(8) (and many others utils;-).

Okay, so as it's not a filesystem, it warrants the de-dup handling. I'd 
appreciate it if this makes it in 2.22-rc2. Please let me know if you want me to 
provide patches and/or test the results.

Many thanks,
Niels