util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ondrej Oprala <ooprala@redhat.com>
To: util-linux@vger.kernel.org
Subject: segfault message supressed with su -c
Date: Tue, 11 Sep 2012 17:01:26 +0200	[thread overview]
Message-ID: <504F5246.4030304@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

Hi,
I've written a tiny patch that should fix this issue with su:
https://bugzilla.redhat.com/show_bug.cgi?id=747592.
None of the shells' output propagates back
to the shell where su was called (except TCSH, which reports segfault
to stdout; I've tested this with sh,ksh,zsh,bash).
So, with this patch, su should print a warning if
WIFSIGNALED(status) && WCOREDUMP(status) is true.

Cheers,
  Ondrej

[-- Attachment #2: DIFF --]
[-- Type: text/plain, Size: 994 bytes --]

>From d4776f487e283649d65be3f3865141a0171a80e7 Mon Sep 17 00:00:00 2001
From: Ondrej Oprala <ooprala@redhat.com>
Date: Tue, 11 Sep 2012 16:39:17 +0200
Subject: [PATCH] su: add segmentation fault reporting of the child process

Child processes that ended with segmentation fault previously
indicated this with return status only. The report is now more
verbose if core dump is allowed.
---
 login-utils/su-common.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index 23ad57d..b0dbed2 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -300,7 +300,11 @@ create_watching_parent (void)
 	}
       if (pid != (pid_t)-1)
 	if (WIFSIGNALED (status))
-	  status = WTERMSIG (status) + 128;
+	  {
+	    status = WTERMSIG (status) + 128;
+	    if (WCOREDUMP (status))
+	      fprintf (stderr, _("Segmentation fault (core dumped)\n"));
+	  }
 	else
 	  status = WEXITSTATUS (status);
       else
-- 
1.7.11.4


             reply	other threads:[~2012-09-11 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 15:01 Ondrej Oprala [this message]
2012-09-11 16:19 ` segfault message supressed with su -c Voelker, Bernhard
2012-09-11 18:02   ` Pádraig Brady
2012-09-11 17:19 ` Pádraig Brady
2012-09-12 10:22   ` Ondrej Oprala
2012-09-21 10:39     ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504F5246.4030304@redhat.com \
    --to=ooprala@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).