util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ayan George <ayan@ayan.net>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Use C99 idioms in kill.c
Date: Thu, 18 Oct 2012 14:12:35 -0400	[thread overview]
Message-ID: <50804693.80009@ayan.net> (raw)
In-Reply-To: <20121018173242.GB16193@x2.net.home>

On 10/18/2012 01:32 PM, Karel Zak wrote:
> On Thu, Oct 18, 2012 at 03:52:30PM +0000, Ayan George wrote:
>> * Moved some declarations closer to where the vairable is used.
>
>   No problem if the declaration is at the begin of any block, like
>
>    if (x) {
>        int y;
>        ...
>    }
>
>   everything other is MESS.
>
>      Karel
>
>

A mess?  Why bother declaring a variable within a block with c99?

It always seemed to make sense to declare a variable closest to where it 
is initialized and used.

Either way -- sorry if it is unacceptable.  I'll retreat to my hole. :^)

-ayan

  reply	other threads:[~2012-10-18 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18 15:52 [PATCH] Use C99 idioms in kill.c Ayan George
2012-10-18 17:32 ` Karel Zak
2012-10-18 18:12   ` Ayan George [this message]
2012-10-18 18:18 ` Dmitry V. Levin
  -- strict thread matches above, loose matches on Subject: below --
2012-10-18 16:00 Ayan George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50804693.80009@ayan.net \
    --to=ayan@ayan.net \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).