Re: [PATCH] libmount: avoid endless loop in, mnt_get_kernel_cmdline_option

[Bernhard Voelker <mail@bernhard-voelker.de>]

On 11/30/2012 05:14 PM, Bernhard Voelker wrote:
> From 4ddf21607847570e1da3b692276f2a8242bd5af6 Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <mail@bernhard-voelker.de>
> Date: Fri, 30 Nov 2012 17:12:12 +0100
> Subject: [PATCH] libmount: avoid endless loop in
>  mnt_get_kernel_cmdline_option

Hi Karel,

BTW: the #ifdef in mnt_get_kernel_cmdline_option doesn't seem
to work to make use of the LIBMOUNT_KERNEL_CMDLINE env var:

--- tests/expected/libmount/utils-kernel-cmdline       2012-11-22 10:41:18.424077009 +0100
+++ tests/output/libmount/utils-kernel-cmdline   2012-12-04 16:17:49.629199061 +0100
@@ -1,5 +1,5 @@
-'selinux=' found, argument: '0'
+'selinux=' not found
 'selinux' not found
-'ro' found
+'ro' not found
 'ro=' not found
-'root=' found, argument: 'UUID=33230ae2-1093-4353-824c-f7ca09a2a882'
+'root=' found, argument: '/dev/sda1'

And ltraced:

 $ export LIBMOUNT_KERNEL_CMDLINE=`pwd`/tests/ts/libmount/files/kernel_cmdline
 $ ltrace -e getenv,fopen -f ./test_mount_utils  --kernel-cmdline selinux=
 getenv("LIBMOUNT_DEBUG")                                                                    = NULL
 fopen("/proc/cmdline", "r")                                                                 = 0x609010
 'selinux=' not found
 +++ exited (status 0) +++

I.e. the utils test may only work on your PC. ;-)


BTW2: the libmount tests all fail when the user has set
LIBMOUNT_DEBUG=0xffff, because the produced output differs.
Maybe LIBMOUNT_DEBUG should be unset in tests/run.sh?

Have a nice day,
Berny