public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Phillip Susi <psusi@ubuntu.com>
To: Karel Zak <kzak@redhat.com>
Cc: Marc MERLIN <marc@merlins.org>, util-linux@vger.kernel.org
Subject: Re: Severe fdisk problem leading to data loss?
Date: Wed, 27 Nov 2013 15:19:40 -0500	[thread overview]
Message-ID: <529653DC.2020600@ubuntu.com> (raw)
In-Reply-To: <20131127200724.GT5572@x2.net.home>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/27/2013 3:07 PM, Karel Zak wrote:
> Seriously, maybe it's fine to ignore the partition with the zero
> type by kernel, but I don't think it's good way for fdisk-like
> applications.
> 
> IMHO it's better to force users to delete the partition than rely
> on the flag. See this thread, user lost data because somehow set
> the type to zero and fdisk reused the space.

Only because fdisk let them set it to zero in the first place ;)

> From my point of view all partitions with non-zero size should be 
> visible by fdisk (or parted) independently on flags or types.

I don't like the idea of showing a different view of the partition
table than DOS/Windows; that way lies suffering.  I can maybe see
complaining that the entry is invalid and letting you change the type
to correct the problem ( assuming the start and length don't put it
outside the disk or overlapping other partitions ), but it should be
very clear that this is a broken entry.

> I'll probably add a warning to fdisk to inform users about the zero
>  type problem.

It already does warn you when you set the type to 0.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSllPcAAoJEI5FoCIzSKrw+6YH/AlZ34QNORe1YxXKAT3g02Ro
YMCVnS8iQdyw15Sj7zJDnl8ZVKkq87jlB/9HuHTrseMSdepK4pt38Gu9nkNXeFiU
7uyk5RLL9C6E90BE1GuV2FT0e02jLUS0BJpylMPFDSdmtNe7/3xVMOlxqkRGycFQ
CF0C2wGV878/pFje4XQbn48WGysVL+BN6PbjdWZZaOqAlldx154la+oYl9h+JkpO
KAfPZdtjIe/q9zXY4hQJzh7VIWgL/vf27/XYnzAXaxBxAiugdUMLinUQJ0j5TwB5
Ju8rN9P9RgQ9SAA6PNTfi5nWYPk1d6brTklQFCHdrGyJ54Pwdm7DKWOGaWxdtqQ=
=rHzX
-----END PGP SIGNATURE-----

  reply	other threads:[~2013-11-27 20:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20131118102051.GA31813@merlins.org>
2013-11-24 13:52 ` Severe fdisk problem leading to data loss? Marc MERLIN
2013-11-25 10:31   ` Karel Zak
2013-11-25 11:59     ` Marc MERLIN
2013-11-27 14:46     ` Phillip Susi
2013-11-27 14:58       ` Karel Zak
2013-11-27 18:25         ` Phillip Susi
2013-11-27 19:58           ` Curtis Gedak
2013-11-27 20:08             ` Phillip Susi
2013-11-27 20:23               ` Curtis Gedak
2013-11-27 21:05                 ` Phillip Susi
2013-11-27 21:07                   ` Curtis Gedak
2013-11-27 23:02                   ` Ángel González
2013-11-27 20:07           ` Karel Zak
2013-11-27 20:19             ` Phillip Susi [this message]
2013-11-27 21:09               ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529653DC.2020600@ubuntu.com \
    --to=psusi@ubuntu.com \
    --cc=kzak@redhat.com \
    --cc=marc@merlins.org \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox