From: "Pádraig Brady" <P@draigBrady.com>
To: Karel Zak <kzak@redhat.com>
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
"Sten Heinze" <shze@gmx.de>,
util-linux@vger.kernel.org
Subject: Re: Automatic SSD trim script
Date: Wed, 11 Dec 2013 10:54:07 +0000 [thread overview]
Message-ID: <52A8444F.2040904@draigBrady.com> (raw)
In-Reply-To: <20131210154442.GC8419@x2.net.home>
On 12/10/2013 03:44 PM, Karel Zak wrote:
> On Mon, Dec 09, 2013 at 02:43:32PM +0100, Lukáš Czerner wrote:
>>> All we need is to link fstrim with libmount and lib/sysfs.c, add a new
>>> option --all and check non-zero /sys/block/<name>/queue/discard_granularity
>>> (or so).
>>
>> Yes and yes. This is the ultimate solution. Simply being able to run
>> fstrim --all to discard free space on all the mounted supported file
>> systems is great idea. In that case we do not need any scripts at
>> all.
>
> Implemented. Sten, maybe you can try fstrim --all from git tree
> in your crontab.
Very nice:
https://git.kernel.org/cgit/utils/util-linux/util-linux.git/commit/?id=36c370c
One foible was it was called multiple times for my /home
Now my /home is mounted a couple of times on my system (why I don't know):
├─/home /dev/sdb1 ext4 rw,relatime,seclabel,user_xattr,barrier=1,data=ordered
│ └─/home /dev/sdb1 ext4 rw,relatime,seclabel,user_xattr,barrier=1,data=ordered
If this was common it might be worth avoiding processing the same entry multiple times.
thanks!
Pádraig
next prev parent reply other threads:[~2013-12-11 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:20 Automatic SSD trim script Sten Heinze
2013-12-06 10:49 ` Karel Zak
2013-12-09 13:43 ` Lukáš Czerner
2013-12-10 15:44 ` Karel Zak
2013-12-11 2:07 ` Sten Heinze
2013-12-11 10:54 ` Pádraig Brady [this message]
2013-12-11 11:36 ` Karel Zak
2013-12-11 16:03 ` Karel Zak
2013-12-17 19:46 ` Marcos Mello
2013-12-17 19:58 ` Marcos Mello
2014-01-13 12:12 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A8444F.2040904@draigBrady.com \
--to=p@draigbrady.com \
--cc=kzak@redhat.com \
--cc=lczerner@redhat.com \
--cc=shze@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox