From: "Pádraig Brady" <P@draigBrady.com>
To: Ruediger Meier <sweet_f_a@gmx.de>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] build-sys: use gettext 0.18.3 if possible
Date: Tue, 10 Jun 2014 14:57:03 +0100 [thread overview]
Message-ID: <53970EAF.4010801@draigBrady.com> (raw)
In-Reply-To: <1402394931-20416-2-git-send-email-sweet_f_a@gmx.de>
On 06/10/2014 11:08 AM, Ruediger Meier wrote:
> autopoint_fun ()
> +{
> + # we have to deal with set -e ...
> + rm -f configure.ac.autogenbak
> + ret="0"
> + GT_VER_MIN="0.18"
> + GT_VER_DEF=$(sed -n 's/AM_GNU_GETTEXT_VERSION(\[\(.*\)\])/\1/p' configure.ac)
> + GT_VER_HAVE="$(gettext --version | head -n 1 | sed 's/.* //g')"
> +
> + tmp=$(echo -e "$GT_VER_MIN\n$GT_VER_HAVE" | sort -V | tail -n1)
> + tmp=$(echo -e "$GT_VER_DEF\n$tmp" | sort -V | head -n1)
You seem to be relying on coreutils here, using sort -V and tail -n
Note echo is exceptionally non portable. Better to use printf instead.
thanks,
Pádraig.
next prev parent reply other threads:[~2014-06-10 13:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 10:08 [PATCH] next try to update gettext version Ruediger Meier
2014-06-10 10:08 ` [PATCH] build-sys: use gettext 0.18.3 if possible Ruediger Meier
2014-06-10 11:52 ` Karel Zak
2014-06-10 12:04 ` Ruediger Meier
2014-06-10 12:16 ` Karel Zak
2014-06-10 12:23 ` Karel Zak
2014-06-10 13:41 ` Ruediger Meier
2014-06-10 13:57 ` Pádraig Brady [this message]
2014-06-10 15:25 ` Ruediger Meier
2014-06-10 17:51 ` Ruediger Meier
[not found] ` <53974319.7040608@gmail.com>
2014-06-11 22:18 ` [PATCH] next try to update gettext version Ruediger Meier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53970EAF.4010801@draigBrady.com \
--to=p@draigbrady.com \
--cc=sweet_f_a@gmx.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox