From: JWP <elseifthen@gmx.com>
To: "Noé RUBINSTEIN" <nrubinstein@aldebaran.com>
Cc: util-linux <util-linux@vger.kernel.org>
Subject: Re: [RFC PATCH] hwclock: --offset: Use offset instead of writing clock
Date: Tue, 07 Oct 2014 11:50:53 -0400 [thread overview]
Message-ID: <54340BDD.7080405@gmx.com> (raw)
In-Reply-To: <CAOJKDvLgeipyRqK8Kwf8=fuz3QQYuzJV_kCEvgA-BJD7p5m_fg@mail.gmail.com>
On 10/07/2014 08:48 AM, Noé RUBINSTEIN wrote:
>> Sure, hwclock already has the ability to track the offset between the
>> Hardware Clock and the System Clock(which presumably is the 'correct' time).
> ...but this information is recorded only when setting the hardware
> clock, which is impossible on some (arguably buggy) targets.
Are you sure that drift factor (re)calculation does not happen if
writing the Hardware Clock fails? I just had a quick look at the
code and it seem that we do not test to see if write fails. So
(re)calculation might work as is?
next prev parent reply other threads:[~2014-10-07 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 9:15 [RFC PATCH] hwclock: --offset: Use offset instead of writing clock Noé Rubinstein
2014-10-07 11:28 ` JWP
2014-10-07 11:52 ` Noé RUBINSTEIN
2014-10-07 12:13 ` JWP
2014-10-07 12:48 ` Noé RUBINSTEIN
2014-10-07 15:19 ` JWP
2014-10-07 15:50 ` JWP [this message]
2014-10-09 8:51 ` Noé RUBINSTEIN
2014-10-09 11:15 ` JWP
2014-10-09 15:05 ` Noé RUBINSTEIN
2014-10-10 0:11 ` JWP
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54340BDD.7080405@gmx.com \
--to=elseifthen@gmx.com \
--cc=nrubinstein@aldebaran.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).