From: JWP <elseifthen@gmx.com>
To: Karel Zak <kzak@redhat.com>
Cc: Sami Kerola <kerolasa@iki.fi>, util-linux@vger.kernel.org
Subject: Re: [PATCH 1/7] hwclock: hctosys drift compensation II
Date: Thu, 16 Oct 2014 19:21:04 -0400 [thread overview]
Message-ID: <544052E0.3080105@gmx.com> (raw)
In-Reply-To: <20141014090311.GM8057@x2.net.home>
On 10/14/2014 05:03 AM, Karel Zak wrote:
> On Mon, Sep 29, 2014 at 12:48:06PM -0400, JWP wrote:
>> On 09/28/2014 01:55 PM, Sami Kerola wrote:
>>> On Sat, 27 Sep 2014, JWP wrote:
>> separate patch changing all occurrences would be preferred? I would
>> be happy to add that to my todo list if the project wants it?
>
> Maybe it would be better to think about whole code refactoring as it's
> horrible code. It's probably last so horrible code in util-linux.
>
> (refactoring means: add control struct, small smart functions to
> modify the struct and high-level functions to implement hwclock
> logic, but it has to be done in easy to review incremental way. It
> means small patches.
I have added it to my todo list.
I would like to make other needed changes first before starting to
refactor, if that is okay with you?
>> Mr. Zak, could you please tell me how to proceed on these changes?
>> Should they all be implemented as Mr. Kerola wrote them?
>> Do you want to tweak the code, or do you want me to resubmit a
>> single patch, or the entire series?
>
> You don't have to resend all, just fixed (updated) patches only. Or
> ideally create your own git repository somewhere (e.g. at github) and
> send pull request (url to the repository) only.
Changes made as requested.
Repository created at GitHub:
https://github.com/jwpi/util-linux
git@github.com:jwpi/util-linux.git
https://github.com/jwpi/util-linux.git
I also sent a pull request to you via GitHub.
>
> Please, try to compose smaller patches next time, for example --get
> is relatively independent change.
Okay, sorry.
>
> Karel
>
next prev parent reply other threads:[~2014-10-16 23:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 15:16 [PATCH 0/7] hwclock patch cover letter JWP
2014-09-27 15:29 ` [PATCH 1/7] hwclock: hctosys drift compensation II JWP
2014-09-28 17:55 ` Sami Kerola
2014-09-29 16:48 ` JWP
2014-10-14 9:03 ` Karel Zak
2014-10-14 9:51 ` Sami Kerola
2014-10-14 10:27 ` Karel Zak
2014-10-16 23:21 ` JWP [this message]
2014-10-20 12:05 ` Karel Zak
2014-10-20 23:35 ` JWP
2014-10-21 9:38 ` Karel Zak
2014-09-27 15:29 ` [PATCH 2/7] hwclock: hctosys drift compensation II COMMENTS JWP
2014-09-27 15:29 ` [PATCH 3/7] hwclock: hctosys drift compensation II MAN JWP
2014-09-27 15:29 ` [PATCH 4/7] hwclock: persistent_clock_is_local JWP
2014-09-27 15:29 ` [PATCH 5/7] hwclock: persistent_clock_is_local MAN JWP
2014-09-27 15:30 ` [PATCH 6/7] hwclock: Add --update option JWP
2014-10-14 9:51 ` Karel Zak
2014-09-27 15:30 ` [PATCH 7/7] hwclock: Add --update option MAN JWP
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544052E0.3080105@gmx.com \
--to=elseifthen@gmx.com \
--cc=kerolasa@iki.fi \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).