util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: JWP <elseifthen@gmx.com>
To: Karel Zak <kzak@redhat.com>
Cc: Sami Kerola <kerolasa@iki.fi>, util-linux@vger.kernel.org
Subject: Re: [PATCH 1/7] hwclock: hctosys drift compensation II
Date: Mon, 20 Oct 2014 19:35:13 -0400	[thread overview]
Message-ID: <54459C31.3060702@gmx.com> (raw)
In-Reply-To: <20141020120550.GB8057@x2.net.home>



On 10/20/2014 08:05 AM, Karel Zak wrote:
> On Thu, Oct 16, 2014 at 07:21:04PM -0400, JWP wrote:
>> Repository created at GitHub:
>> https://github.com/jwpi/util-linux
>> git@github.com:jwpi/util-linux.git
>> https://github.com/jwpi/util-linux.git
> 
>  Thanks, merged. I have also added some (I hope correct) notes to
>  the begin of the hwclock man page.

Hello Karel,

Yes, what you wrote is correct. However, I think some of the wording
could be misinterpreted, especially:

"hwclock automatically compensates Hardware Clock to account for 
 systematic drift before using it to set the System Clock by --hctosys."

Someone may think the Hardware Clock itself was being compensated.

I have made a commit to change the wording slightly, I will send you a
pull request after I send this email.

Thank you for fixing hwclock's man page formatting! It was on my todo list.

Thank you for taking time to review and merge my work, and allowing me to
contribute to util-linux.

I have some util-linux workflow questions:

* Do you want pull requests sent to you via github?
* If yes, what, if anything, should be posted to the mailing list?

Will

  reply	other threads:[~2014-10-20 23:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 15:16 [PATCH 0/7] hwclock patch cover letter JWP
2014-09-27 15:29 ` [PATCH 1/7] hwclock: hctosys drift compensation II JWP
2014-09-28 17:55   ` Sami Kerola
2014-09-29 16:48     ` JWP
2014-10-14  9:03       ` Karel Zak
2014-10-14  9:51         ` Sami Kerola
2014-10-14 10:27           ` Karel Zak
2014-10-16 23:21         ` JWP
2014-10-20 12:05           ` Karel Zak
2014-10-20 23:35             ` JWP [this message]
2014-10-21  9:38               ` Karel Zak
2014-09-27 15:29 ` [PATCH 2/7] hwclock: hctosys drift compensation II COMMENTS JWP
2014-09-27 15:29 ` [PATCH 3/7] hwclock: hctosys drift compensation II MAN JWP
2014-09-27 15:29 ` [PATCH 4/7] hwclock: persistent_clock_is_local JWP
2014-09-27 15:29 ` [PATCH 5/7] hwclock: persistent_clock_is_local MAN JWP
2014-09-27 15:30 ` [PATCH 6/7] hwclock: Add --update option JWP
2014-10-14  9:51   ` Karel Zak
2014-09-27 15:30 ` [PATCH 7/7] hwclock: Add --update option MAN JWP

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54459C31.3060702@gmx.com \
    --to=elseifthen@gmx.com \
    --cc=kerolasa@iki.fi \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).