From: JWP <elseifthen@gmx.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH 0/5] hwclock: clean up messages
Date: Fri, 24 Oct 2014 07:15:55 -0400 [thread overview]
Message-ID: <544A34EB.507@gmx.com> (raw)
In-Reply-To: <20141024110803.GB10134@x2.net.home>
On 10/24/2014 07:08 AM, Karel Zak wrote:
> On Thu, Oct 23, 2014 at 10:44:31PM -0400, JWP wrote:
>> This patch set cleans up various message output.
>> It contains cosmetic changes only.
>>
>> J William Piggott (5):
>> hwclock: Remove newline from 'date' debug output
>> hwclock: clean up message periods/full stops
>> hwclock: add message line breaks
>> hwclock: Fix --date debug messages
>> hwclock: version prints out of order
>
> I'm going to merge these patches, but as a long term solution it would
> better to use include/debug.h stuff (see for example
> misc-utils/whereis.c or libmount/src/init.c).
>
> The debug.h provides more elegant way for debug messages. It's
> possible to define mask to specify wanted messages and all is
> controlled by <NAME>_DEBUG= env. variable etc.
>
> It's probably too verbose for hwclock --debug, but let's ignore this
> problem for now. I'll make the output more user friendly ASAP.
Cool, I was not aware of debug.h. I will check it out and include it
in my hwclock refactoring todo notes.
>
> Karel
>
next prev parent reply other threads:[~2014-10-24 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 2:44 [PATCH 0/5] hwclock: clean up messages JWP
2014-10-24 11:08 ` Karel Zak
2014-10-24 11:15 ` JWP [this message]
2014-10-24 11:48 ` Benno Schulenberg
2014-10-24 12:18 ` Karel Zak
2014-10-24 12:22 ` JWP
2014-10-24 13:18 ` Benno Schulenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A34EB.507@gmx.com \
--to=elseifthen@gmx.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).