util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: JWP <elseifthen@gmx.com>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: Karel Zak <kzak@redhat.com>, Util-Linux <util-linux@vger.kernel.org>
Subject: Re: [PATCH 4/4] docs: improve wording and formattin of man page of hwclock
Date: Tue, 04 Nov 2014 08:16:18 -0500	[thread overview]
Message-ID: <5458D1A2.40106@gmx.com> (raw)
In-Reply-To: <1415049315.2564297.186608257.366970B7@webmail.messagingengine.com>

On 11/03/2014 04:15 PM, Benno Schulenberg wrote:

> Well, there are several problems with your (and also Karels) version
> of the text.  First, "automatically".  The word suggests to me that
> there is/was a way to do this unautomatically, that is: by the use of
> an option.  But is was never possible to make hwclock set the System
> Clock to a drift-compensated time without touching the Hardware Clock
> nor the adjtime file.  Second, "compensates time [...] to account for".
> The expression in English is " to compensate something /for/ a deviance" --
> there should be no "to account".  But the interposing of "read from the
> Hardware Clock" makes the use of this expression difficult to grasp.
> So it's better to rewrite the whole thing.  Third, a "the" is needed
> before "time".  Fourth, the "This functionality" referring to --adjust
> no longer being necessary during boot is awkward; it's second word
> can simply de dropped.

I do not disagree with you here. I did not want to be heavy handed when
editing Karel's words, because it is his project and I am new here. I only
wanted to make clear to the reader that the Hardware Clock itself was not
being altered.

> 
> So... my suggestion:
> 
> "Since v2.26 hwclock --hctosys does a better job at setting the System Clock:
> it no longer simply copies the time from the Hardware Clock to the System Clock,
> but it reads the Hardware Clock, applies a compensation for the systematic drift
> to this read time, and sets the System Clock to the resulting time.  Thus it is
> no longer necessary to run hwclock --adjust before doing hwclock --hctosys, and
> therefore hwclock can be used very early on in the boot process when the root
> filesystem is still read-only."
> 
> Any amendments?

Nope, that seems quite complete Benno!

  reply	other threads:[~2014-11-04 13:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27 21:18 [PATCH 1/4] docs: spelling, wording, and grammar fixes in the man page of whereis Benno Schulenberg
2014-10-27 21:18 ` [PATCH 2/4] docs: fix some wording and formatting in man page of swapon Benno Schulenberg
2014-10-31  9:48   ` Karel Zak
2014-10-27 21:18 ` [PATCH 3/4] textual: slice up the usage text of swapon for ease of translation Benno Schulenberg
2014-10-27 21:24   ` Benno Schulenberg
2014-10-31  9:32     ` Karel Zak
2014-10-31  9:48   ` Karel Zak
2014-10-27 21:18 ` [PATCH 4/4] docs: improve wording and formattin of man page of hwclock Benno Schulenberg
2014-10-28  1:09   ` JWP
2014-10-28 20:02     ` Benno Schulenberg
2014-10-31  9:51       ` Karel Zak
2014-11-02 17:53         ` JWP
2014-11-03 21:15           ` Benno Schulenberg
2014-11-04 13:16             ` JWP [this message]
2014-11-18 13:05               ` Karel Zak
2014-11-18 19:48                 ` Benno Schulenberg
2014-11-19  7:26                   ` Karel Zak
2014-10-31  9:47 ` [PATCH 1/4] docs: spelling, wording, and grammar fixes in the man page of whereis Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5458D1A2.40106@gmx.com \
    --to=elseifthen@gmx.com \
    --cc=bensberg@justemail.net \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).