Util-Linux package development
 help / color / mirror / Atom feed
From: JWP <elseifthen@gmx.com>
To: Benno Schulenberg <bensberg@justemail.net>, util-linux@vger.kernel.org
Subject: Re: [PATCH] docs: fix two "maybe be" duplications in program comments
Date: Sun, 18 Jan 2015 16:17:59 -0500	[thread overview]
Message-ID: <54BC2307.9090806@gmx.com> (raw)
In-Reply-To: <1421614227-5938-1-git-send-email-bensberg@justemail.net>

On 01/18/2015 03:50 PM, Benno Schulenberg wrote: 
>  	if (!tb->is_term)
>  		return 0;
>  
> -	/* reduce columns with extreme fields
> -	 */
> +	/* reduce columns with extreme fields */
>  	if (width > tb->termwidth && extremes) {
>  		DBG(TAB, ul_debugobj(tb, "   reduce width (extreme columns)"));
>

This is a common practice to add some delimiting space between a
comment and the code; just as the the empty line above it does.


> @@ -710,7 +708,7 @@ static int recount_widths(struct libscols_table *tb, struct libscols_buffer *buf
>  		if (width < tb->termwidth && scols_table_is_maxout(tb)) {
>  			DBG(TAB, ul_debugobj(tb, "   enlarge width (max-out)"));
>  
> -			/* try enlarge all columns */
> +			/* try enlarging all columns */
>  			while (width < tb->termwidth) {
>  				scols_reset_iter(&itr, SCOLS_ITER_FORWARD);
>  				while (scols_table_next_column(tb, &itr, &cl) == 0) {
> @@ -735,7 +733,7 @@ static int recount_widths(struct libscols_table *tb, struct libscols_buffer *buf
>  	}
>  
>  	/* bad, we have to reduce output width, this is done in two steps:
> -	 * 1/ reduce columns with a relative width and with truncate flag
> +	 * 1) reduce columns with a relative width and with truncate flag
>  	 * 2) reduce columns with a relative width without truncate flag
>  	 */
>  	trunc_only = 1;
> 

  reply	other threads:[~2015-01-18 21:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18 20:50 [PATCH] docs: fix two "maybe be" duplications in program comments Benno Schulenberg
2015-01-18 21:17 ` JWP [this message]
2015-01-26 10:29 ` Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BC2307.9090806@gmx.com \
    --to=elseifthen@gmx.com \
    --cc=bensberg@justemail.net \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox