From: Bernhard Voelker <mail@bernhard-voelker.de>
To: Sami Kerola <kerolasa@iki.fi>,
Patrick Plagwitz <patrick.plagwitz@fau.de>
Cc: util-linux@vger.kernel.org
Subject: Re: logger: Segmentation fault when reading from stdin and writing to socket
Date: Tue, 07 Apr 2015 08:36:33 +0200 [thread overview]
Message-ID: <55237AF1.3010004@bernhard-voelker.de> (raw)
In-Reply-To: <alpine.LNX.2.03.1504062226540.593@iki.fi>
On 04/06/2015 11:50 PM, Sami Kerola wrote:
> On Mon, 6 Apr 2015, Patrick Plagwitz wrote:
>> The attached patch does just that.
> The below appears to fix the issue.
Sami, your patch differs from Patrick's just in a newline, and you only
turned his - already great - description into a commit message.
Therefore I think setting Patrick as the author would be both correct
and just fair.
Please note that seeing the own name in the commit log encourages
people to continue contributing in future.
BTW: what about the memleak he reported?
Thanks & have a nice day,
Berny
next prev parent reply other threads:[~2015-04-07 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 2:02 logger: Segmentation fault when reading from stdin and writing to socket Patrick Plagwitz
2015-04-06 21:50 ` Sami Kerola
2015-04-07 6:36 ` Bernhard Voelker [this message]
2015-04-07 8:00 ` Sami Kerola
2015-04-07 8:43 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55237AF1.3010004@bernhard-voelker.de \
--to=mail@bernhard-voelker.de \
--cc=kerolasa@iki.fi \
--cc=patrick.plagwitz@fau.de \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox