Util-Linux package development
 help / color / mirror / Atom feed
From: J William Piggott <elseifthen@gmx.com>
To: Alexey Galakhov <agalakhov@gmail.com>, util-linux@vger.kernel.org
Subject: Re: [PATCH] hwclock: flush stdout in hwclock -c
Date: Sun, 19 Apr 2015 20:34:19 -0400	[thread overview]
Message-ID: <5534498B.4080803@gmx.com> (raw)
In-Reply-To: <1429197987-8751-1-git-send-email-agalakhov@gmail.com>


Hello Alexey,

 I've been advocating for the removal of the compare function. One of my
 justifications for doing so is that it has been broken from day one and
 therefore nobody can be using for anything.

 So could you tell me how you are using it, and what useful purpose it is
 serving for you?

Thanks
 William

On 04/16/2015 11:26 AM, Alexey Galakhov wrote:
> This allows using hwclock -c in automated test scripts that parse
> its output line-by-line. The standard output is flushed before
> each 10 second delay.
> 
> Signed-off-by: Alexey Galakhov <agalakhov@gmail.com>
> ---
>  sys-utils/hwclock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sys-utils/hwclock.c b/sys-utils/hwclock.c
> index e1e5816..4cdb2ea 100644
> --- a/sys-utils/hwclock.c
> +++ b/sys-utils/hwclock.c
> @@ -1532,6 +1532,7 @@ static int compare_clock (const bool utc, const bool local_opt)
>  			printf("hw-time      system-time         freq-offset-ppm   tick\n");
>  			printf("%10.0f   %10.6f\n", (double) time1_hw, time1_sys);
>  		}
> +		fflush(stdout);
>  		sleep(10);
>  	}
>  
> 

  reply	other threads:[~2015-04-20  0:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-16 15:26 [PATCH] hwclock: flush stdout in hwclock -c Alexey Galakhov
2015-04-20  0:34 ` J William Piggott [this message]
2015-04-20  7:28   ` Alexey Galakhov
2015-04-21 15:19     ` J William Piggott
2015-04-21 15:50       ` Alexey Galakhov
2015-04-21 19:12         ` J William Piggott
2015-04-27  8:27 ` Karel Zak
2015-04-27 21:27   ` J William Piggott
2015-04-27 21:42     ` Alexey Galakhov
2015-04-28  6:50       ` Bernhard Voelker
2015-04-28 11:27       ` J William Piggott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5534498B.4080803@gmx.com \
    --to=elseifthen@gmx.com \
    --cc=agalakhov@gmail.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox