Util-Linux package development
 help / color / mirror / Atom feed
From: Stanislav Brabec <sbrabec@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] fsck: implement fsck -r {fd}
Date: Tue, 28 Apr 2015 17:28:57 +0200	[thread overview]
Message-ID: <553FA739.5010007@suse.cz> (raw)
In-Reply-To: <20150428115210.GW27969@ws.net.home>

Karel Zak wrote:
>
>   Applied, thanks. See notes below.
>
> On Mon, Apr 27, 2015 at 05:20:55PM +0200, Stanislav Brabec wrote:
>> Note: Code in if and else is intentionally partially duplicated. Current
>> human readable output of floats does not conform to locale conventions,
>> and may be changed in future. But we want to keep machine readable output
>> exactly same as it is now.
>
> The question is if we can change the human readable output. It was
> requested by Google and I guess they parse the output.
>
I created the alternative output format just for purpose of machine 
parsing: No need for scanf(), just space separated values.

I was also thinking about possibility to switch between human-readable 
and easily parseable output even to a specified FD, but I did not 
implement it.

I could be easy: Positive number would mean easily parseable output, 
negative number human readable. Just zero will be a problem (but we can 
still parse it on ASCII level and allow -r-0.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec@suse.cz
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                 fax:  +420 284 084 001
Czech Republic                                    http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76

      parent reply	other threads:[~2015-04-28 15:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 15:20 [PATCH] fsck: implement fsck -r {fd} Stanislav Brabec
2015-04-28 11:52 ` Karel Zak
2015-04-28 14:15   ` Theodore Ts'o
2015-04-28 15:56     ` Stanislav Brabec
2015-04-28 17:13       ` Theodore Ts'o
2015-04-28 18:30         ` Stanislav Brabec
2015-04-28 15:28   ` Stanislav Brabec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553FA739.5010007@suse.cz \
    --to=sbrabec@suse.cz \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox