From: "Pádraig Brady" <P@draigBrady.com>
To: Mike Frysinger <vapier@gentoo.org>, util-linux@vger.kernel.org
Subject: Re: [PATCH] build-sys: fix parallel builds w/setarch links
Date: Tue, 05 May 2015 11:37:33 +0100 [thread overview]
Message-ID: <55489D6D.9010303@draigBrady.com> (raw)
In-Reply-To: <1430711464-4943-1-git-send-email-vapier@gentoo.org>
On 04/05/15 04:51, Mike Frysinger wrote:
> From: Mike Frysinger <vapier@chromium.org>
>
> The symlink generation tries to write to the sys-utils/ subdir but does
> not make sure that dir exists. This can sometimes lead to parallel build
> failures when building out-of-tree
> $(SETARCH_MAN_LINKS):
> + $(AM_V_at) test -d $(dir $@) || mkdir -p $(dir $@)
> $(AM_V_GEN)echo ".so man8/setarch.8" > $@
>
> install-exec-hook-setarch:
The `test -d ... ||` bit is racy and redundant I think
cheers,
Pádraig
next prev parent reply other threads:[~2015-05-05 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 3:51 [PATCH] build-sys: fix parallel builds w/setarch links Mike Frysinger
2015-05-05 10:37 ` Pádraig Brady [this message]
2015-05-10 15:28 ` Mike Frysinger
2015-05-10 17:20 ` Bruce Dubbs
2015-05-10 20:38 ` Isaac Dunham
2015-05-11 8:05 ` Karel Zak
2015-05-16 17:50 ` Peter Cordes
2015-05-17 5:53 ` Mike Frysinger
2015-05-05 10:47 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55489D6D.9010303@draigBrady.com \
--to=p@draigbrady.com \
--cc=util-linux@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox