From: Bruce Dubbs <bruce.dubbs@gmail.com>
To: Mike Frysinger <vapier@gentoo.org>, util-linux@vger.kernel.org
Subject: Re: [PATCH] cal: drop trailing blank line
Date: Mon, 23 May 2016 16:30:37 -0500 [thread overview]
Message-ID: <5743767D.3010904@gmail.com> (raw)
In-Reply-To: <1464037332-21996-1-git-send-email-vapier@gentoo.org>
Mike Frysinger wrote:
> There's no history to be found behind this, and the comment in the
> code indicates no one else knows, and it makes me angry :).
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> misc-utils/cal.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/misc-utils/cal.c b/misc-utils/cal.c
> index 3e20530..479c967 100644
> --- a/misc-utils/cal.c
> +++ b/misc-utils/cal.c
> @@ -767,9 +767,6 @@ static void yearly(const struct cal_control *ctl)
> my_putstring("\n\n");
> }
> monthly(ctl);
> -
> - /* Is empty line at the end year output really needed? */
> - my_putstring("\n");
> }
>
> /*
Personally I like the blank line. It sets off the cal output from the
shell prompt making it easier to read. It is basically adding the
equivalent of the css property padding-bottom="1em".
I note that if doing a 'cal -y' that there is also a blank line between
the year and February. That should stay also.
-- Bruce Dubbs
linuxfromscratch.org
next prev parent reply other threads:[~2016-05-23 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 21:02 [PATCH] cal: drop trailing blank line Mike Frysinger
2016-05-23 21:30 ` Bruce Dubbs [this message]
2016-05-23 22:58 ` Mike Frysinger
2016-05-23 22:59 ` Mike Frysinger
2016-05-23 23:32 ` Bruce Dubbs
2016-05-24 1:02 ` Mike Frysinger
2018-01-25 4:22 ` Mike Frysinger
2018-01-25 11:26 ` J William Piggott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5743767D.3010904@gmail.com \
--to=bruce.dubbs@gmail.com \
--cc=util-linux@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox