From: "L. Walsh" <lkml@tlinx.org>
To: Ray Strode <halfline@gmail.com>
Cc: util-linux@vger.kernel.org, Karel Zak <kzak@redhat.com>,
Lennart Poettering <lennart@poettering.net>,
Ray Strode <rstrode@redhat.com>
Subject: Re: [PATCH] login-utils: import environment from user manager on systemd systems
Date: Thu, 27 Oct 2016 20:02:46 -0700 [thread overview]
Message-ID: <5812BFD6.3050006@tlinx.org> (raw)
In-Reply-To: <1477427661-19788-1-git-send-email-halfline@gmail.com>
Ray Strode wrote:
> From: Ray Strode <rstrode@redhat.com>
>
> If the user is using a systemd system, then its useful to grab the
> environment from the systemd user manager process.
>
----
The other issue you don't really touch on, is why should this be hard-
coded in various programs when this is seems exactly like why PAM was
invented.
I.e. why not have a PAM module, say "pam_sysd_env", that gets the
env from the systemd user module(s), so any programs using
PAM can include in their security/authentication stack, the same
way pam_env might be used now (not that they are necessarily mutually
exclusive).
One of the issues with systemd is that it is doesn't re-use
existing interfaces, but tends to force programs to make changes to work
with sysd, where if it used the existing interfaces, no program-specific
changes might be required and no explicit dependencies are built in
tools so that the same tools can be used on sysd systems, vs. non-sysd
systems.
Minimizing code changes in existing, working code seems like a
safer design decision. It is especially true that the more code paths
that are added to programs, the more test paths and opportunities for
failure
are added.
next prev parent reply other threads:[~2016-10-28 3:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 20:34 [PATCH] login-utils: import environment from user manager on systemd systems Ray Strode
2016-10-25 21:06 ` Linda Walsh
2016-10-26 19:38 ` Ray Strode
2016-10-27 21:53 ` L. Walsh
2016-10-28 15:06 ` Ray Strode
2016-10-28 3:02 ` L. Walsh [this message]
2016-10-28 15:14 ` Ray Strode
2016-12-07 19:45 ` Ray Strode
2016-12-07 20:04 ` Ruediger Meier
2016-12-08 11:24 ` Karel Zak
2016-12-08 15:00 ` Ray Strode
2016-12-08 18:39 ` Fwd: " Ray Strode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5812BFD6.3050006@tlinx.org \
--to=lkml@tlinx.org \
--cc=halfline@gmail.com \
--cc=kzak@redhat.com \
--cc=lennart@poettering.net \
--cc=rstrode@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox