From: L A Walsh <lkml@tlinx.org>
To: Karel Zak <kzak@redhat.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
util-linux@vger.kernel.org, LKML <linux-lkml@vger.kernel.org>
Subject: Re: [PATCH] build-sys: fix configure --without-systemd
Date: Tue, 28 Jan 2020 16:15:07 -0800 [thread overview]
Message-ID: <5E30CE8B.1080007@tlinx.org> (raw)
In-Reply-To: <20200128120733.s3n7f5gidsorwii7@ws.net.home>
On 2020/01/28 04:07, Karel Zak wrote:
> On Fri, Jan 24, 2020 at 12:29:47PM -0500, Theodore Ts'o wrote:
>
>> AC_ARG_WITH([systemd],
>> AS_HELP_STRING([--without-systemd], [do not build with systemd support]),
>> - [], [with_systemd=check]
>> + [], [with_systemd=no]
>>
>
> The current default is to check for the libraries, if installed than
> enable systemd support. This is generic way we use for many libs and
> features. Why do you think that explicit --enable-* will be better?
>
---
Perhaps Ted didn't realize that the line he replaced
was only the default action (1st bracket pair empty => no option).
Initially, I thought the same until I read further
down (two lines):
have_systemd=no
AS_IF([test "x$with_systemd" != xno], [ ...
test for positive case ]
If any of the tests fail, then 'have_systemd=no'
is the option passed along.
I don't _think_ Ted is asking for for the default to be
changed, as the subject of his note states it is
to fix the "--without-systemd" case, but a
fix was added for a bug that wasn't present,
so I don't think he knowingly did what he
intended to do.
prev parent reply other threads:[~2020-01-29 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 17:29 [PATCH] build-sys: fix configure --without-systemd Theodore Ts'o
2020-01-28 12:07 ` Karel Zak
2020-01-29 0:15 ` L A Walsh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E30CE8B.1080007@tlinx.org \
--to=lkml@tlinx.org \
--cc=kzak@redhat.com \
--cc=linux-lkml@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox